SOLR-14828: reduce 'error' logging noise in BaseCloudSolrClient.requestWithRetryOnStaleState #1825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stWithRetryOnStaleState
| return requestWithRetryOnStaleState(request, retryCount + 1, inputCollections); | ||
| } | ||
| } else { | ||
| log.info("request was not communication error it seems"); | ||
| } | ||
| log.error("Request to collection {} failed due to ({}) {}, retry={} commError={} errorCode={} ", |
There was a problem hiding this comment.
Since you add - retrying to the info logging above, maybe add something like - max retries hit here
There was a problem hiding this comment.
max retries hit is a little tricky to determine exactly since e.g. commError and other things influence the logic. But inclusion of MAX_STALE_RETRIES in the logging could make it clear(er) when "max retries hit" was likely the case.
HoustonPutman
approved these changes
Sep 14, 2020
cpoerschke
commented
Sep 15, 2020
solr/solrj/src/java/org/apache/solr/client/solrj/impl/BaseCloudSolrClient.java
Outdated
Show resolved
Hide resolved
asfgit
pushed a commit
that referenced
this pull request
Sep 24, 2020
…stWithRetryOnStaleState (#1825)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-14828