Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOLR-8785: Use Metrics library for core metrics #25

Closed
wants to merge 3 commits into from

Conversation

randomstatistic
Copy link

There were three main areas that used the copied classes in org.apache.solr.util.stats:

  • AnalyticsStatisticsCollector
  • Overseer.Stats
  • RequestHandlerBase

This patch adds depreciation tags to all the copied classes, and also replaces all usage of those classes with classes from the Metrics library.
I added one new class (org.apache.solr.util.stats.Metrics) to provide some common access patterns for metrics gathering.

This patch only adds Registry-based tracking to RequestHandlerBase, although all three areas are a fit for it. The effect is that all one needs to do is add a Reporter to the SharedMetricRegistry named “solr.registry.requesthandler” and all named request handler stats will be exported automatically.

Compatibility notes:

  • The “totalTime” stat has been deleted from all three areas. This never seemed very useful, and Metrics didn’t support it in the Timer class, so it would have required some extra code to keep.
  • RequestHandler stats are now persistent, and will no longer reset on reload.

@ctargett
Copy link
Contributor

https://issues.apache.org/jira/browse/SOLR-8785 was implemented in Solr 6.4, so this PR can be closed.

@ctargett ctargett closed this Jan 18, 2019
bszabo97 pushed a commit to bszabo97/lucene-solr that referenced this pull request Mar 18, 2021
zacharymorn added a commit to zacharymorn/lucene-solr that referenced this pull request Mar 27, 2021
…s are indexed for a FacetLabel (apache#25)

(cherry picked from commit 3648a1020a8ab6b729ed53e0360499e624bb0cd1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants