LUCENE-8287: In ContextQuery, use a more comprehensive check for an empty prefix automaton #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Going through old patches trying to clean some up before the end of the year. @jtibshirani this patch looks good to me, would you like to commit it? |
|
Thanks @madrob for pinging on this, I'll commit in the next few days. |
jtibshirani
changed the title
jtibshirani
force-pushed
the
bugfix/empty-context-query
branch
from
95b8fa6
to
9ca7ce1
Compare
jtibshirani
added a commit
that referenced
this pull request
Jan 2, 2021
…utomaton. (#383) Context queries check if the wrapped automaton is empty, and if so return an empty automaton. This commit improves the check for empty automata, which allows for handling an empty PrefixCompletionQuery as well.
uschindler
pushed a commit
to uschindler/lucene-solr
that referenced
this pull request
Jan 6, 2021
…utomaton. (apache#383) Context queries check if the wrapped automaton is empty, and if so return an empty automaton. This commit improves the check for empty automata, which allows for handling an empty PrefixCompletionQuery as well.
ctargett
pushed a commit
to ctargett/lucene-solr
that referenced
this pull request
Jan 11, 2021
…utomaton. (apache#383) Context queries check if the wrapped automaton is empty, and if so return an empty automaton. This commit improves the check for empty automata, which allows for handling an empty PrefixCompletionQuery as well.
epugh
pushed a commit
to epugh/lucene-solr-1
that referenced
this pull request
Jan 15, 2021
…utomaton. (apache#383) Context queries check if the wrapped automaton is empty, and if so return an empty automaton. This commit improves the check for empty automata, which allows for handling an empty PrefixCompletionQuery as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #375.