LUCENE-8286: UH initial support for Weight.matches #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ructor (to reduce number of args to all the OffsetStrategy impls)
Was a non-issue when OE == term but more of an issue in other cases. Now matches order within the Passage is more sane in such cases.
…e merged. When matches overlap, the formatted passage could contain weird end/open pairs. Formatting as if the matches were merged is more sane I think.
…when different. Weight Matches highlighting needs this for some cases; especially when requireFieldMatch/fieldMatcher is in use. Refactored FieldOffsetStrategy.getOffsetsEnum to take a LeafReader not IndexReader.
… not necessary anymore. Updated based on MI improvements in master. With subMatches, we have better fidelity on span queries. And since MI can handle span queries now, no need to touch PhraseHelper. * added to UHComponents: query, and highlightFlags * updated tests to handle with/without WEIGHT_MATCHES * TestUnifiedHighlighterStrictPhrases uses more randomization. Removed brittle score calculation dependence. * Test Passage matches data is in order TODO: OE freq & term()
…tead of its parts. Resolved nocommits.
yonik
pushed a commit
to yonik/lucene-solr
that referenced
this pull request
Oct 30, 2019
* Adding back joda-time dependency for S3 * Skip sync and recovery for SHARED replicas prior to leader election
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UnifiedHighlighter support for Weight.matches. See LUCENE-8286