Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LUCENE-8286: UH initial support for Weight.matches #409

Closed
wants to merge 14 commits into from

Commits on Aug 3, 2018

  1. Configuration menu
    Copy the full SHA
    8a12584 View commit details
    Browse the repository at this point in the history
  2. LUCENE-8286: Refactor out a UHComponents of FieldOffsetStrategy const…

    …ructor
    
    (to reduce number of args to all the OffsetStrategy impls)
    dsmiley committed Aug 3, 2018
    Configuration menu
    Copy the full SHA
    d01b968 View commit details
    Browse the repository at this point in the history
  3. LUCENE-8286 OffsetsEnum should order by endOffset following startOffset.

    Was a non-issue when OE == term but more of an issue in other cases.
    Now matches order within the Passage is more sane in such cases.
    dsmiley committed Aug 3, 2018
    Configuration menu
    Copy the full SHA
    df83981 View commit details
    Browse the repository at this point in the history
  4. LUCENE-8286 UH Formatter: Overlapping matches within passage should b…

    …e merged.
    
    When matches overlap, the formatted passage could contain weird end/open pairs.
    Formatting as if the matches were merged is more sane I think.
    dsmiley committed Aug 3, 2018
    Configuration menu
    Copy the full SHA
    73f8888 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    93c4663 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    a3ef8be View commit details
    Browse the repository at this point in the history
  7. LUCENE-8286 Overlay LeafReader with offsets with the real LeafReader …

    …when different.
    
    Weight Matches highlighting needs this for some cases; especially
     when requireFieldMatch/fieldMatcher is in use.
    Refactored FieldOffsetStrategy.getOffsetsEnum to take a LeafReader not IndexReader.
    dsmiley committed Aug 3, 2018
    Configuration menu
    Copy the full SHA
    42947da View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    4d1b633 View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2018

  1. LUCENE-8286 UH: Use MI.getSubMatches(). Removed PhraseHelper changes;…

    … not necessary anymore.
    
    Updated based on MI improvements in master.
    With subMatches, we have better fidelity on span queries.
    And since MI can handle span queries now, no need to touch PhraseHelper.
    * added to UHComponents: query, and highlightFlags
    * updated tests to handle with/without WEIGHT_MATCHES
    * TestUnifiedHighlighterStrictPhrases uses more randomization.
      Removed brittle score calculation dependence.
    * Test Passage matches data is in order
    TODO: OE freq & term()
    dsmiley committed Aug 13, 2018
    Configuration menu
    Copy the full SHA
    6098a36 View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2018

  1. Configuration menu
    Copy the full SHA
    39a5c62 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2018

  1. Configuration menu
    Copy the full SHA
    bbeeb44 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2018

  1. LUCENE-8286: UH use one UHComponents field in FieldOffsetStrategy ins…

    …tead of its parts.
    
    Resolved nocommits.
    dsmiley committed Aug 27, 2018
    Configuration menu
    Copy the full SHA
    376ac79 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a3d87e2 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f054ffc View commit details
    Browse the repository at this point in the history