SOLR-9840: Add a unit test for LDAP integration (Hrishikesh Gadre, Kevin Risden) #591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
risdenk
force-pushed
the
jira/solr-9840
branch
3 times, most recently
from
fe4ef77
to
c330ff0
Compare
|
Helps to review if you use the github filter filter to look at the non .txt and .sha1 files. |
risdenk
force-pushed
the
jira/solr-9840
branch
2 times, most recently
from
9bacaa3
to
3ec58c2
Compare
…vin Risden) Signed-off-by: Kevin Risden <krisden@apache.org>
risdenk
force-pushed
the
jira/solr-9840
branch
from
3ec58c2
to
40606cd
Compare
|
working on rebasing to latest master to make sure still valid. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial pass at merging LDAP support. precommit and the test change (
TestSolrCloudWithHadoopAuthPlugin) passes. Sadly this requires a LOT of test dependencies from Apache DS. I took trial and error to make sure it was the minimal dependencies needed to make this test work.