LUCENE-8973: XYRectangle2D should work on float space #865
Conversation
|
Note: Should XYRectangle holds the values as floats instead of doubles? |
# Conflicts: # lucene/sandbox/src/java/org/apache/lucene/document/XYShapeBoundingBoxQuery.java
There was a problem hiding this comment.
I'm not sure this is the right fix, but I agree we should review usage of doubles and floats here. Ideally we'd use floats everywhere since this matches the accuracy we support, but I believe we use doubles in some places (Tessellator?) for the purpose of sharing code with the geo code.
|
|
||
| /** Builds a Rectangle2D from rectangle */ | ||
| public static XYRectangle2D create(XYRectangle rectangle) { | ||
| return new XYRectangle2D((float)rectangle.minX, (float)rectangle.maxX, (float)rectangle.minY, (float)rectangle.maxY); |
There was a problem hiding this comment.
I don't think this is right, float casts will round to the nearest float while we should actually round towards zero so that queries are accurate in the encoded space?
There was a problem hiding this comment.
Not sure if the encoding works as you said. I test the following:
public void testEncoding() {
double val = ShapeTestUtil.nextDouble();
double castVal = (double)(float) val;
double qVal = XYEncodingUtils.decode(XYEncodingUtils.encode(val));
assertEquals(castVal, qVal, 0.0);
}
This seems to hold true.
# Conflicts: # lucene/sandbox/src/java/org/apache/lucene/document/XYShapeBoundingBoxQuery.java
# Conflicts: # lucene/sandbox/src/java/org/apache/lucene/document/XYShapeBoundingBoxQuery.java
|
I have updated the PR so the XYRectangle2D is now a Component2D |
|
Fixed in #872 |
New implementation of XYRectangle 2D that works on the float space. Because the encoding is not lineal, working on the encoding space changes the spatial relationship between the bounding box and the other objects.