LUCENE-9030: Fix different Solr- and WordnetSynonymParser behaviour #981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue where sets of equivalent synonyms in the Wordnet format are parsed and added to the SynonymMap in a way that leads to the original input token not being typed as "word" but as SYNONYM instead. Also the original token doesn't appear first in the token stream output, which is the case for equivalent solr formatted synonym files. Currently the WordnetSynonymParser adds all combinations of input/output pairs of a synset entry into the synonym map, while the SolrSynonymParser excludes those where input and output term are the same. This change adds the same behaviour to WordnetSynonymParser and adds tests that show the two formats are outputting the same token order and types now.
|
Could you add a CHANGES.txt entry? All looks good other than that, and precommit passes locally for me. |
|
@romseygeek thanks for the review, I updated the CHANGES.txt. |
asfgit
pushed a commit
that referenced
this pull request
Nov 13, 2019
…981) This fixes an issue where sets of equivalent synonyms in the Wordnet format are parsed and added to the SynonymMap in a way that leads to the original input token not being typed as "word" but as SYNONYM instead. Also the original token doesn't appear first in the token stream output, which is the case for equivalent solr formatted synonym files. Currently the WordnetSynonymParser adds all combinations of input/output pairs of a synset entry into the synonym map, while the SolrSynonymParser excludes those where input and output term are the same. This change adds the same behaviour to WordnetSynonymParser and adds tests that show the two formats are outputting the same token order and types now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where sets of equivalent synonyms in the Wordnet format are
parsed and added to the SynonymMap in a way that leads to the original input
token not being typed as "word" but as SYNONYM instead. Also the original token
doesn't appear first in the token stream output, which is the case for
equivalent solr formatted synonym files.
Currently the WordnetSynonymParser adds all combinations of input/output pairs
of a synset entry into the synonym map, while the SolrSynonymParser excludes
those where input and output term are the same. This change adds the same
behaviour to WordnetSynonymParser and adds tests that show the two formats are
outputting the same token order and types now.