Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAHOUT-1933 #304

Closed
wants to merge 2 commits into from
Closed

MAHOUT-1933 #304

wants to merge 2 commits into from

Conversation

dustinvanstee
Copy link
Contributor

This is a proposed new look for the Mahout website. Wanted to get this out to the community asap. Need to work on the readme to enable other contributors ....

@rawkintrevo
Copy link
Contributor

Thanks for the contribution Dustin!

Screen shots would be helpful for those doing drive bys- if you have them.

@rawkintrevo
Copy link
Contributor

OK, just took it for a test drive.

Look really good.

Needed to do this sudo gem install jekyll-paginate

I feel like there ought to be a Gemfile / Gemfile.lock that takes care of all that?

Also would like to see Jekyl Bootloader mixed in- NONE of these are pre-requisites for merging.

@andrewpalumbo @andrewmusselman when you get a minute, and anyone else interested in the website rebuild.

I think the idea here is not to build a full website on this PR. We want a feature branch where we can all edit and make changes collaboratively (with contribution from the community).

Once we have it worked to a good point- then we can "Go Live"

@rawkintrevo
Copy link
Contributor

@pferrel @andrewpalumbo I esp like the Blog Feed- not only bc it features all of my blogs, but there has been talk for years about getting rolling on mahout blogs, and now we have some in the wild and more coming (pat and I do), so instead of trying to host our own blog, a feed that links to hosted mahout blog posts would be pretty dope. (we could actually go a ways back on this to back fill content).

@andrewpalumbo
Copy link
Member

This is great to see happening.. thanks very much @dustinvanstee. I will try to build when I have the chance. @rawkintrevo @pferrel absolutely a blog feed will be great.

@andrewmusselman
Copy link
Contributor

Looks great, I'm all for it.

@dustinvanstee it looks like the home page is in HTML; I'm happy with that but if we intend to have everything in markdown and then have jekyll turn that into HTML would that be possible to do with the home page for consistency?

@rawkintrevo
Copy link
Contributor

@andrewmusselman @dustinvanstee was looking at that too... seems the file is misnamed- the internals of it are basically a blank page of markdown.

I think that index.html should be index.md (tried, this works fine). Also on the layouts, I think maybe default should be homepage.html since that is what is doing in reality.

All in all, trivial things, and design choices. I'm still LGTM +1

@andrewmusselman
Copy link
Contributor

Works for me; thanks again @dustinvanstee, good move.

@rawkintrevo
Copy link
Contributor

I also want to call out a big +1 on mathjax support- the dssvd and dspca pages now render the markdown correctly- a little late easter egg for anyone reviewing...

@rawkintrevo
Copy link
Contributor

So this was merged to the website branch. Any ideas how to close the PR, or should @dustinvanstee just close it on his end?

@andrewpalumbo
Copy link
Member

andrewpalumbo commented Apr 23, 2017 via email

@dustinvanstee dustinvanstee deleted the MAHOUT-1933 branch June 28, 2017 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants