Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PoC] Require maven 3.1.1 #6

Closed
wants to merge 1 commit into from
Closed

[PoC] Require maven 3.1.1 #6

wants to merge 1 commit into from

Conversation

slachiewicz
Copy link
Member

No description provided.

@@ -173,7 +139,8 @@
These files contains the expected output of this component and can not contain a license header.
-->
<exclude>src/it/*/expected*.txt</exclude>
</excludes>
<exclude>src/it/**/*.iml</exclude>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should really .gitignore these

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right!

@@ -26,7 +26,7 @@
import java.util.Collection;

/**
* Maven project dependency graph builder API, neutral against Maven 2 or Maven 3.
* Maven project dependency graph builder API, based on Maven 3.1+.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't this specifically the point of this API? i.e. to bridge between 2 and 3? or was that a different artifact?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that was for maven-artifact-transfer. Yes initially that was a bridge but because now prerequisite is maven 3.1.1, no longer need old stuff here
@rfscholte

@rfscholte
Copy link
Contributor

I'm going to close this one. Both (and only) dependency-tree and maven-artifact-transfer contain bridging code. It there is a chance maven-artifact-resolver will introduce new classes, so we will still need this mechanism.
Better leave it as it is, so we can extend more easily in the future (or spend time to move the related code to maven-artifact-transfer)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants