Skip to content

[MSHARED-1071] Drop maven 3.0 compatibility, Maven 3.2.5, Injects #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 20, 2022
Merged

[MSHARED-1071] Drop maven 3.0 compatibility, Maven 3.2.5, Injects #10

merged 1 commit into from
Aug 20, 2022

Conversation

gnodet
Copy link
Contributor

@gnodet gnodet commented Jan 24, 2022

No description provided.

@gnodet gnodet requested review from cstamas and michael-o January 24, 2022 20:10
slachiewicz
slachiewicz requested changes Jan 24, 2022
View reviewed changes
Copy link
Member

@slachiewicz slachiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was rejected some time ago

@gnodet
Copy link
Contributor Author

gnodet commented Jan 24, 2022

That was rejected some time ago

What was rejected exactly ? The drop of legacy maven 3.0.x support ?

@slachiewicz
Copy link
Member

Yes #6

@gnodet
Copy link
Contributor Author

gnodet commented Jan 24, 2022

Yes #6

Does this mean this artifact should be deprecated and somehow merged into maven-core ? Same as maven-artifact-transfer / maven-common-artifact-filters ?

@gnodet
Copy link
Contributor Author

gnodet commented Jan 25, 2022

Yes #6

Does this mean this artifact should be deprecated and somehow merged into maven-core ? Same as maven-artifact-transfer / maven-common-artifact-filters ?

Something like https://github.com/gnodet/maven/tree/mat ?

@slachiewicz slachiewicz requested a review from rfscholte January 25, 2022 07:03
cstamas
cstamas approved these changes Jan 26, 2022
View reviewed changes
Copy link
Member

@cstamas cstamas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

slawekjaranowski
slawekjaranowski requested changes Jan 26, 2022
View reviewed changes
Copy link
Member

@slawekjaranowski slawekjaranowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jira issue will be appreciated.

michael-o
michael-o requested changes Feb 7, 2022
View reviewed changes
Copy link
Member

@michael-o michael-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look here: https://cwiki.apache.org/confluence/display/MAVEN/Maven+Ecosystem+Cleanup#MavenEcosystemCleanup-ResolverandMaven
Maven 3.1.1 comes with Aether not Resolver, does this matter?

@gnodet
Copy link
Contributor Author

gnodet commented Feb 7, 2022

Look here: https://cwiki.apache.org/confluence/display/MAVEN/Maven+Ecosystem+Cleanup#MavenEcosystemCleanup-ResolverandMaven
Maven 3.1.1 comes with Aether not Resolver, does this matter?

@michael-o I would prefer aligning everything on using resolver, but that would mean moving the requirements to Maven 3.5.x.

@michael-o
Copy link
Member

Look here: https://cwiki.apache.org/confluence/display/MAVEN/Maven+Ecosystem+Cleanup#MavenEcosystemCleanup-ResolverandMaven
Maven 3.1.1 comes with Aether not Resolver, does this matter?

@michael-o I would prefer aligning everything on using resolver, but that would mean moving the requirements to Maven 3.5.x.

I don't disagree, in fact I would prefer to move ALL components to 3.5.4 after Maven 4.0.0-alpha-1 has been released, but consider that this is used in many other components, thus forcing them to update as well. :-(

@gnodet
Copy link
Contributor Author

gnodet commented Feb 8, 2022

Look here: https://cwiki.apache.org/confluence/display/MAVEN/Maven+Ecosystem+Cleanup#MavenEcosystemCleanup-ResolverandMaven
Maven 3.1.1 comes with Aether not Resolver, does this matter?

@michael-o I would prefer aligning everything on using resolver, but that would mean moving the requirements to Maven 3.5.x.

I don't disagree, in fact I would prefer to move ALL components to 3.5.4 after Maven 4.0.0-alpha-1 has been released, but consider that this is used in many other components, thus forcing them to update as well. :-(

If we start defining a new API to hide the resolver, this component may simply be deprecated at some point.

@michael-o
Copy link
Member

Look here: https://cwiki.apache.org/confluence/display/MAVEN/Maven+Ecosystem+Cleanup#MavenEcosystemCleanup-ResolverandMaven
Maven 3.1.1 comes with Aether not Resolver, does this matter?

@michael-o I would prefer aligning everything on using resolver, but that would mean moving the requirements to Maven 3.5.x.

I don't disagree, in fact I would prefer to move ALL components to 3.5.4 after Maven 4.0.0-alpha-1 has been released, but consider that this is used in many other components, thus forcing them to update as well. :-(

If we start defining a new API to hide the resolver, this component may simply be deprecated at some point.

Who's actually using this component to estimate the impact?

@slawekjaranowski
Copy link
Member

Who's actually using this component to estimate the impact?

more or less usage report: https://mvnrepository.com/artifact/org.apache.maven.shared/maven-dependency-tree/usages

@slawekjaranowski
Copy link
Member

And issue https://issues.apache.org/jira/browse/MSHARED-1071

slawekjaranowski
slawekjaranowski approved these changes May 7, 2022
View reviewed changes
Copy link
Member

@slawekjaranowski slawekjaranowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Connect with issue and go ...

@slawekjaranowski
Copy link
Member

I think that it is still valuable, @gnodet could you rebase and resolve conflicts ... if you don't have time I can take care about it.

@slawekjaranowski slawekjaranowski changed the title Drop maven 3.0 compatibility [MSHARED-1071] Drop maven 3.0 compatibility, Maven 3.2.5, Injects Jul 30, 2022
michael-o
michael-o requested changes Jul 30, 2022
View reviewed changes
@slawekjaranowski slawekjaranowski self-assigned this Aug 16, 2022
@slawekjaranowski
Copy link
Member

Any remarks for it?
I'm going to merge it in a few days.

michael-o
michael-o requested changes Aug 16, 2022
View reviewed changes
@slawekjaranowski slawekjaranowski force-pushed the update-mvn-3.1 branch 2 times, most recently from cddccb3 to 600e094 Compare August 16, 2022 14:23
@slachiewicz
Copy link
Member

docs also should be updated:

Component entry point is DependencyGraphBuilder, which will delegate to appropriate implementation for either Maven 2, Maven 3.0.x or Maven 3.1.x.

@slawekjaranowski slawekjaranowski merged commit 80cadf4 into apache:master Aug 20, 2022
@jira-importer
Copy link

Resolve #86

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slawekjaranowski slawekjaranowski slawekjaranowski approved these changes

@slachiewicz slachiewicz slachiewicz approved these changes

@rfscholte rfscholte Awaiting requested review from rfscholte

@cstamas cstamas Awaiting requested review from cstamas

@michael-o michael-o Awaiting requested review from michael-o

Assignees

@slawekjaranowski slawekjaranowski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@gnodet @slachiewicz @michael-o @slawekjaranowski @jira-importer @cstamas