[MENFORCER-272] Site fixes #22
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
|
@reviewbybees done |
stephenc
approved these changes
Jun 12, 2017
|
@jglick can you create a JIRA issue in MENFORCER project and I'll see about merging tomorrow |
|
@jglick you need to update the commit messages to contain |
· Grammar error. · Pick up fix of mojohaus/extra-enforcer-rules#13. · Fix Javadoc error considered fatal by JDK 8.
|
done |
|
@jglick merged in https://svn.apache.org/viewvc?view=revision&revision=1798818 , can you close this PR (the fun of GitHub PRs on SVN based project) |
jglick
referenced
this pull request
Jun 15, 2017
· Grammar error. · Pick up fix of mojohaus/extra-enforcer-rules#13. · Fix Javadoc error considered fatal by JDK 8. Submitted by Jesse Glick (jglick at apache dot org) git-svn-id: https://svn.apache.org/repos/asf/maven/enforcer/trunk@1798818 13f79535-47bb-0310-9956-ffa450edef68
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MENFORCER-272
Some fixes I found desirable or necessary when testing site generation locally.
@reviewbybees for my colleagues