New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MNG-6776] Inconsistent list of parameters for MojoDescriptor (#584) #1361
Conversation
As a result of apache/maven-plugin-tools#253 |
maven-plugin-api/src/main/java/org/apache/maven/plugin/descriptor/MojoDescriptor.java
Show resolved
Hide resolved
maven-plugin-api/src/main/java/org/apache/maven/plugin/descriptor/MojoDescriptor.java
Show resolved
Hide resolved
@slawekjaranowski This is a cherrypick from master. It does not change behavior. Unmodifiables should on main only and require a new issue. Note that this will need special handling in plugin tools otherwise it will fail. |
maven-plugin-api/src/main/java/org/apache/maven/plugin/descriptor/MojoDescriptor.java
Outdated
Show resolved
Hide resolved
c4c43e2
to
1c15f42
Compare
maven-plugin-api/src/main/java/org/apache/maven/plugin/descriptor/MojoDescriptor.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good, maybe it's also worth to backport to 3.8.x?
I was thinking about the same. Will prepare after this one. |
@cstamas Any objections before I backport this one? |
1c15f42
to
16ee683
Compare
It may lead to confusion as parameters (list) and parametersMap (map) may "fall apart" easily. Also, parametersMap did not honor parameter ordering while parameters list makes it look that order is important. Simply, rebuild the map always and retain ordering as well. Added UT and also removed some cruft provided by java8. Co-authored-by: Marc Wrobel <marc.wrobel@gmail.com> Co-authored-by: Slawomir Jaranowski <s.jaranowski@gmail.com> (cherry picked from commit cc51006) (cherry picked from commit 5ce5591) (cherry picked from commit 47e2d68) --- https://issues.apache.org/jira/browse/MNG-7309
16ee683
to
b23afbc
Compare
It may lead to confusion as parameters (list) and
parametersMap (map) may "fall apart" easily.
Also, parametersMap did not honor parameter
ordering while parameters list makes it look
that order is important.
Simply, rebuild the map always and retain
ordering as well.
Added UT and also removed some cruft provided
by java8.
https://issues.apache.org/jira/browse/MNG-7309
Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[MNG-XXX] SUMMARY
,where you replace
MNG-XXX
andSUMMARY
with the appropriate JIRA issue.[MNG-XXX] SUMMARY
.Best practice is to use the JIRA issue title in both the pull request title and in the first line of the commit message.
mvn clean verify
to make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.