Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNG-6776] Inconsistent list of parameters for MojoDescriptor (#584) #1361

Merged
merged 1 commit into from Jan 6, 2024

Conversation

michael-o
Copy link
Member

It may lead to confusion as parameters (list) and
parametersMap (map) may "fall apart" easily.

Also, parametersMap did not honor parameter
ordering while parameters list makes it look
that order is important.
Simply, rebuild the map always and retain
ordering as well.

Added UT and also removed some cruft provided
by java8.


https://issues.apache.org/jira/browse/MNG-7309

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MNG-XXX] SUMMARY,
    where you replace MNG-XXX and SUMMARY with the appropriate JIRA issue.
  • Also format the first line of the commit message like [MNG-XXX] SUMMARY.
    Best practice is to use the JIRA issue title in both the pull request title and in the first line of the commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the Core IT successfully.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@michael-o
Copy link
Member Author

As a result of apache/maven-plugin-tools#253

@michael-o
Copy link
Member Author

@slawekjaranowski This is a cherrypick from master. It does not change behavior. Unmodifiables should on main only and require a new issue. Note that this will need special handling in plugin tools otherwise it will fail.

Copy link
Member

@kwin kwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now.

Copy link
Member

@slachiewicz slachiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good, maybe it's also worth to backport to 3.8.x?

@michael-o
Copy link
Member Author

good, maybe it's also worth to backport to 3.8.x?

I was thinking about the same. Will prepare after this one.

@michael-o
Copy link
Member Author

@cstamas Any objections before I backport this one?

It may lead to confusion as parameters (list) and
parametersMap (map) may "fall apart" easily.

Also, parametersMap did not honor parameter
ordering while parameters list makes it look
that order is important.
Simply, rebuild the map always and retain
ordering as well.

Added UT and also removed some cruft provided
by java8.

Co-authored-by: Marc Wrobel <marc.wrobel@gmail.com>
Co-authored-by: Slawomir Jaranowski <s.jaranowski@gmail.com>

(cherry picked from commit cc51006)
(cherry picked from commit 5ce5591)
(cherry picked from commit 47e2d68)
---

https://issues.apache.org/jira/browse/MNG-7309
@asfgit asfgit merged commit b23afbc into maven-3.9.x Jan 6, 2024
22 of 29 checks passed
@michael-o michael-o deleted the MNG-6776-maven-3.9.x branch January 6, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
7 participants