-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Maven Site Plugin AND Maven Fluido Skin #525
base: master
Are you sure you want to change the base?
Conversation
We should check it ... by other hands
I not checked all pages 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
more testing required ... I see empty pages
It is broken, the parsers are strict now for sections: D:\Entwicklung\Projekte\maven-site [bump-site-and-fluido-version ≡ +0 ~2 -0 !]> git diff content/markdown/what-is-maven.md
diff --git a/content/markdown/what-is-maven.md b/content/markdown/what-is-maven.md
index 9a8f73d4..bb848972 100644
--- a/content/markdown/what-is-maven.md
+++ b/content/markdown/what-is-maven.md
@@ -1,4 +1,4 @@
-## Introduction
+# Introduction
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file |
Which release notes are empty? |
b5e3196
to
331ab8c
Compare
@slawekjaranowski This should fix it. The Markdown files were logically incorrect. |
So the build should fail when page is not generated at all due to error. |
@kwin, WDYT? |
Comes from https://issues.apache.org/jira/browse/MSKINS-230. We need to decide whether we want to keep it it have bootstrap style enforced. |
From the top of my head I have no idea because this is now only with Markdown and most of the parsing is done with Flexmark anyway. But some of the strictness has been added by @kwin recently. The purpose is that the output should be parseable again from a Doxia point of view. Broken output cannot be parsed :-( |
I have not deliberately changed anything about being more strict with section nesting, I think we should still allow starting with an h2. Could be an unintended side effect of fixing the nesting levels. Do we have a minimum example in MD? Any warning emitted? |
There is no warning, just no output. |
I have found another severe bug I need to report: As soon as auto anchors are enabled title for the document is not extracted/filled, if you do this then it works again:
|
I will hold off new releases until this issues is resolved. |
Minimal MD without any output and broken HTML:
output:
|
I will factor out the document fixes first... |
5717f42
to
eecb6c9
Compare
eecb6c9
to
a005e6a
Compare
Both need to be updated in tandem to get proper rendering results.
Addresses one of the issues from https://the-asf.slack.com/archives/C7Q9JB404/p1715479275966359