Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MWRAPPER-104] add prettier config for shell #84

Merged
merged 3 commits into from
Feb 5, 2024

Conversation

bmarwell
Copy link
Contributor

@bmarwell bmarwell commented Jan 13, 2023

This is an alternate proposal for running a bash linter. This time it integrates with spotless (and you can use spotlesss:apply). The other approach is using shellcheckk (#82) which is a little more known and does not require npm modules, but does not integrate with spotless as nicely.

Signed-off-by: Benjamin Marwell bmarwell@apache.org

Fixes MWRAPPER-104


Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MWRAPPER-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MWRAPPER-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@bmarwell bmarwell marked this pull request as ready for review January 13, 2023 20:18
@bmarwell
Copy link
Contributor Author

You might want to talk about:
https://github.com/apache/maven-wrapper/pull/84/files#diff-9c5fb3d1b7e3b0f54bc5c4182965c4fe1f9023d449017cece3005d3f90e8e4d8R110-R111

onlymvnw uses a few places with spaces ( case) and > &2) wheras mvnw uses case) and >&2. So both will work for me, we just would need to decide.

Copy link
Member

@slawekjaranowski slawekjaranowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok for me

@slawekjaranowski
Copy link
Member

By the way issue will be appreciated for it.

@bmarwell bmarwell changed the title [BUILD] add prettier config for shell [MWRAPPER-104] add prettier config for shell Mar 20, 2023
@bmarwell bmarwell force-pushed the build_spotless_prettier_shell branch from 5b3d44a to bb0d151 Compare March 20, 2023 06:46
Copy link
Member

@slawekjaranowski slawekjaranowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please apply new format to make a build pass 😄

@slawekjaranowski slawekjaranowski self-assigned this Mar 20, 2023
@bmarwell
Copy link
Contributor Author

bmarwell commented Feb 1, 2024

@slachiewicz @slawekjaranowski rebased and added a commit which applies the prettier config

@slawekjaranowski
Copy link
Member

@bmarwell thanks ... I did forgot it 😄

I see that we should first update parent to the latest in order to build under JDK 21

@bmarwell
Copy link
Contributor Author

bmarwell commented Feb 1, 2024

I see that we should first update parent to the latest in order to build under JDK 21

Was about to say the same. Yup. There are a couple more PRs we should put into the next release.

@bmarwell bmarwell force-pushed the build_spotless_prettier_shell branch from f549226 to cba755d Compare February 2, 2024 15:08
@bmarwell bmarwell force-pushed the build_spotless_prettier_shell branch from fdeed11 to 732c014 Compare February 2, 2024 15:11
pom.xml Outdated Show resolved Hide resolved
@bmarwell bmarwell merged commit 6d4c5ea into master Feb 5, 2024
51 checks passed
@bmarwell bmarwell deleted the build_spotless_prettier_shell branch February 5, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants