spelling: excident

[jsoref]

split from #100

This is for consistency. I know it's a public API. But, I don't know if this is the word you want. If it is, we can add the @deprecated annotation. If it isn't, then we should figure out the right word and fix the others too.

[michael-o]

The problem for this word is that it is not even listed in the Oxford nor Merriam-Webster dictionary. Even if you are a native English speaker, it be quite difficult to understand incident/excident. Is this the meaning?

[jsoref]

I doubt it. Do you understand the code enough to be able to / can you try to read it and then describe what the code is interested in describing? (try to avoid using anything that sounds similar to any of the candidate word roots).

[michael-o]

Incident comes from the graph theory: https://en.wikipedia.org/wiki/Degree_%28graph_theory%29, but I cannot find excident as the opposide term for. I consider this as a madeup word.

[jsoref]

I studied graph theory starting in middle school. I know the other thing is a made up word.

But, the problem is... consider lines...
What is the opposite of a perpendicular line? Is it ...

• a parallel line?
• a line that intersects but not at a 90-degree angle?
• a line that is skew?

What precise aspect of lines is this thing trying to express?

[michael-o]

I assume that due to the directed graph nature, it shall decribe all edges I depent, but have not a common parent vertex (see definition for incident). My graph theory knowledge is highly rusty from first semester.

[jsoref]

https://proofwiki.org/wiki/Definition:Incident_(Graph_Theory)

Offers "incident to" and "incident from".

Offhand, I'd suggest moving away from graph theory towards packaging or something else.

Graph theory while interesting isn't really going to help someone figure this stuff out.

I mean, it's possible to replace all incidents of incident/excident w/ incidentTo/incidentFrom, but that won't make the code easier to read.

[michael-o]

So why not named them: excident => addDependsOn and incident => addDependedBy or similar? Just like JIRA linking: "is dependent upon" and "depends upon".

[jsoref]

Well, ideally we'd pick things not likely to be typo'd (your second one would be Depended). Anyway, I'm more or less willing to take any pair of things you're happy w/.\

one pair to consider is into and from -- they're clearly distinct, they're short, and they have the same character count.

Possibly linkInto, linkFrom, addLinkInto. Not sure I like it. I really didn't come here to rewrite terminology. I have a toolchain that uses maven, and I figured I owed maven a PR...

[atanasenko]

2cents: why not addInNode()/addOutNode() (renaming exNodes->outNodes)? Simple and concise.

[jsoref]

I can live with that.

[slachiewicz]

this is change in maven-compat and this module is deprecated IMHO we should not invest time to do changes here

[michael-o]

I agree with @slachiewicz and did not notice this in the first place. I will close the PR. @jsoref, thank you anyway. Please continue contributing if you find something wrong.