Spelling non-API change #100

jsoref · 2017-01-23T05:03:46Z

No description provided.

* system * tokenizer * toolchain * trailing * transitive * unsupported * version * artifact * attachment * codehaus * colleagues * comparison * concurrency * configure * creation * dependency * descriptor * downstream * efficient * elements * encountered * encounters * environments * executed * explicitly * happens * hierarchical * hierarchy * ignore * implemented * implementers * independence * indicates * inheritance * inherited * inherits * install * interface * javascript * laziness * management * maven * metadata * mgmt * minimalist * nonexistent * objects * overridden * print * project * properties * recessive * referring * repository * representation * retrieval * retrieve * rigorous * should * spontaneously * subsequent

jsoref · 2017-01-23T05:07:59Z

maven-compat/src/main/java/org/apache/maven/repository/MetadataGraphNode.java

    }

-    public MetadataGraphNode addExident( MetadataGraphNode node )
+    public MetadataGraphNode addExcident( MetadataGraphNode node )


This would be an api change. I'm not even sure if this is a correct word.
I'm fairly confident that you are using two spellings for the same concept.

jsoref · 2017-01-23T05:10:33Z

maven-compat/src/main/java/org/apache/maven/repository/MetadataResolutionRequest.java

    }

-    public List<ArtifactRepository> getRemoteRepostories()
+    public List<ArtifactRepository> getRemoteRepositories()


This is probably an api change.
I can provide deprecation markers and/or split this into a distinct PR (applies for all similar items)

jsoref · 2017-01-23T05:12:22Z

maven-core/src/main/java/org/apache/maven/project/ProjectSorter.java

        }

-        for ( Vertex projectVertex : dag.getVerticies() )
+        for ( Vertex projectVertex : dag.getVertices() )


this change stands alone, I can't find anything else that uses this spelling, but lots of things use the corrected spelling....

jsoref · 2017-01-23T05:12:41Z

maven-core/src/main/java/org/apache/maven/repository/DelegatingLocalArtifactRepository.java

    }

-    public LocalArtifactRepository getIdeWorspace()
+    public LocalArtifactRepository getIdeWorkspace()


This would be an api change

jsoref · 2017-01-23T05:13:56Z

...test/java/org/apache/maven/lifecycle/internal/stub/LifecycleExecutionPlanCalculatorStub.java



-    public int getNumberOfExceutions( ProjectBuildList projectBuildList )
+    public int getNumberOfExecutions( ProjectBuildList projectBuildList )


I'm hoping this isn't really a public api, but if it is...

jsoref · 2017-01-23T05:18:46Z

...uilder/src/test/java/org/apache/maven/model/interpolation/AbstractModelInterpolatorTest.java

    }

-    protected void assertColllectorState( int numFatals, int numErrors, int numWarnings,
+    protected void assertCollectorState( int numFatals, int numErrors, int numWarnings,


I guess this is an api

michael-o · 2017-01-23T09:29:38Z

Hi Josh, thanks for the PR. I have seen that you did the same for Tomcat. We should split this into two parts:

non-API change
API change with deprecations and proper docs

Please create two tickets, two PRs, I wil take care of.

jsoref · 2017-01-24T04:52:16Z

@michael-o split -- please follow-up in #103 as that's a messier kettle

michael-o · 2017-01-28T16:25:20Z

@jsoref I am somewhat confused by the new PRs. I wanted two distinct PRs. Can you do that?

jsoref · 2017-01-29T03:44:03Z

@michael-o : this PR is roughly "non-API change". I split off #101 for the API change (and included deprecation, but not docs, that's too much to ask).
#102 is a bug fix, I think, so I split it out.
#103 isn't really finished, because well, I'm not sure what the right word is.

michael-o · 2017-01-29T13:44:39Z

maven-core/src/main/resources/META-INF/plexus/components.xml

          <field-name>_cipher</field-name>
        </requirement>
        <requirement>
-          <role>org.sonatype.plexus.components.sec.dispatcher.PasswordDecryptor</role>


This is a typo in Plexus Sec Dispatcher we can't fix here. Please drop. You can, of course, add a comment for the typo.

michael-o · 2017-01-29T13:47:21Z

maven-core/src/main/resources/META-INF/plexus/components.xml

        </requirement>
        <requirement>
-          <role>org.sonatype.plexus.components.sec.dispatcher.PasswordDecryptor</role>
-          <field-name>_decryptors</field-name>


michael-o · 2017-01-29T13:49:10Z

I am about to merge this PR, but for one commit which has to be undone.

jsoref · 2017-01-29T16:19:15Z

sonatype/plexus-sec-dispatcher#4

michael-o · 2017-01-29T16:32:19Z

You have renamed to mngt, but missed to rename physical directories also.

michael-o · 2017-01-31T15:31:15Z

Can you rebase your changes and squash into one commit? I want to pull them in with MNG-6146.

jsoref · 2017-02-01T04:05:04Z

done

michael-o · 2017-02-01T10:27:42Z

Testing your PR, two issues:

Please resolve the marked conflicts
One test fails because you missed to rename a directory:

Test set: org.apache.maven.project.PomConstructionTest

Tests run: 122, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 4.906 sec <<< FAILURE! - in org.apache.maven.project.PomConstructionTest
testInterpolationWithSystemProperty(org.apache.maven.project.PomConstructionTest) Time elapsed: 0.031 sec <<< ERROR!
org.apache.maven.project.ProjectBuildingException: 1 problem was encountered while building the effective model
[FATAL] Non-readable POM D:\Projekte\maven\maven-core\src\test\resources-project-builder\system-property-interpolation: D:\Projekte\maven\maven-core\src\test\resources-project-builder\system-property-interpolation (Das System kann die angegebene Datei nicht finden) @
for project at D:\Projekte\maven\maven-core\src\test\resources-project-builder\system-property-interpolation
at org.apache.maven.model.building.DefaultModelProblemCollector.newModelBuildingException(DefaultModelProblemCollector.java:197)
at org.apache.maven.model.building.DefaultModelBuilder.readModel(DefaultModelBuilder.java:598)
at org.apache.maven.model.building.DefaultModelBuilder.build(DefaultModelBuilder.java:273)
at org.apache.maven.project.DefaultProjectBuilder.build(DefaultProjectBuilder.java:161)
at org.apache.maven.project.DefaultProjectBuilder.build(DefaultProjectBuilder.java:119)
at org.apache.maven.project.PomConstructionTest.buildPom(PomConstructionTest.java:1861)
at org.apache.maven.project.PomConstructionTest.buildPom(PomConstructionTest.java:1831)
at org.apache.maven.project.PomConstructionTest.testInterpolationWithSystemProperty(PomConstructionTest.java:1521)

Please update.

jsoref · 2017-02-02T02:34:35Z

Updated

michael-o · 2017-02-02T08:28:51Z

Testing your changes now: https://builds.apache.org/job/maven-3.x-jenkinsfile/job/MNG-6146/

…and documentation Spelling fixes: * system * tokenizer * toolchain * trailing * transitive * unsupported * version * artifact * attachment * codehaus * colleagues * comparison * concurrency * configure * creation * dependency * descriptor * downstream * efficient * e.g. * elements * encountered * encounters * environments * executed * explicitly * happens * hierarchical * hierarchy * ignore * implemented * implementers * independence * indicates * inheritance * inherited * inherits * install * interface * javascript * laziness * management * maven * metadata * mgmt * minimalist * nonexistent * objects * overridden * print * project * properties * recessive * referring * repository * representation * retrieval * retrieve * rigorous * should * spontaneously * subsequent Literal fixes: * use static final values Style fixes: * use the proper term for char U+002D (-) hyphen(-minus) instead of dash This closes apache#100

…)selection using --projects. Closes apache#100.

jira-importer · 2025-07-06T09:05:31Z

Resolve #7298

jsoref commented Jan 23, 2017

View reviewed changes

This was referenced Jan 24, 2017

Spelling api #101

Closed

spelling: vertices #102

Closed

spelling: excident #103

Closed

jsoref force-pushed the spelling branch from e6a0242 to 9036fe2 Compare January 24, 2017 04:51

jsoref changed the title ~~Spelling~~ Spelling non-API change Jan 29, 2017

michael-o reviewed Jan 29, 2017

View reviewed changes

jsoref force-pushed the spelling branch from 9036fe2 to a384291 Compare January 29, 2017 16:02

jsoref force-pushed the spelling branch from a384291 to 49e967f Compare January 29, 2017 16:52

jsoref force-pushed the spelling branch 2 times, most recently from 23fd7ae to 6440c30 Compare February 1, 2017 04:04

jsoref force-pushed the spelling branch 2 times, most recently from a5138c1 to bd0b2ba Compare February 2, 2017 02:33

asfgit closed this in 1740265 Feb 3, 2017

gnodet pushed a commit to gnodet/maven that referenced this pull request Nov 20, 2024

[MNG-6511] Testing whether projects can be marked optional during (de…

0e982c2

…)selection using --projects. Closes apache#100.



		public int getNumberOfExceutions( ProjectBuildList projectBuildList )
		public int getNumberOfExecutions( ProjectBuildList projectBuildList )

Spelling non-API change #100

Spelling non-API change #100

Uh oh!

Conversation

jsoref commented Jan 23, 2017

Uh oh!

jsoref Jan 23, 2017

Choose a reason for hiding this comment

Uh oh!

jsoref Jan 23, 2017

Choose a reason for hiding this comment

Uh oh!

jsoref Jan 23, 2017

Choose a reason for hiding this comment

Uh oh!

jsoref Jan 23, 2017

Choose a reason for hiding this comment

Uh oh!

jsoref Jan 23, 2017

Choose a reason for hiding this comment

Uh oh!

jsoref Jan 23, 2017

Choose a reason for hiding this comment

Uh oh!

michael-o commented Jan 23, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jsoref commented Jan 24, 2017

Uh oh!

michael-o commented Jan 28, 2017

Uh oh!

jsoref commented Jan 29, 2017

Uh oh!

michael-o Jan 29, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

michael-o Jan 29, 2017

Choose a reason for hiding this comment

Uh oh!

michael-o commented Jan 29, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jsoref commented Jan 29, 2017

Uh oh!

michael-o commented Jan 29, 2017

Uh oh!

michael-o commented Jan 31, 2017

Uh oh!

jsoref commented Feb 1, 2017

Uh oh!

michael-o commented Feb 1, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test set: org.apache.maven.project.PomConstructionTest

Uh oh!

jsoref commented Feb 2, 2017

Uh oh!

michael-o commented Feb 2, 2017

Uh oh!

jira-importer commented Jul 6, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

michael-o commented Jan 23, 2017 •

edited

Loading

michael-o Jan 29, 2017 •

edited

Loading

michael-o commented Jan 29, 2017 •

edited

Loading

michael-o commented Feb 1, 2017 •

edited

Loading