Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNG-6071] Normalize relative paths for working directory #198

Merged
merged 1 commit into from
Jan 27, 2020
Merged

Conversation

slachiewicz
Copy link
Member

Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very like the surefire issue.
But we need to write tests

@Tibor17
Copy link
Contributor

Tibor17 commented Dec 8, 2018

@slachiewicz
It would be worth to commit this change in concrete version. Why we did not negotiate the version for such simple fix on mailing list?

@slachiewicz
Copy link
Member Author

i need to write unit tests - i run multiple runa by hand while investigating root couse, but now I have less time to add few more tests to code. I look into this later. I already send few other pathes to mailing list - waiting for review and more are ready.

@slachiewicz
Copy link
Member Author

@eolivelli @Tibor17 I'm unable to create a unit test for this change. Inside maven everything works fine, only with surefire it makes the problem because getClass.getResource inside java rejects "." inside classpath entry.
It this change would not make any side effects - it would be good to see clean paths to poms/workspace

Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's ship it in the current form as far as all tests pass on our Jenkins matrix

Jenkinsfile Outdated Show resolved Hide resolved
@asfgit asfgit merged commit cdb2cd0 into master Jan 27, 2020
@asfgit asfgit deleted the MNG-6071 branch January 28, 2020 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants