METRON-2117: [UI] Aligning models to grouping feature #1412
Conversation
| import { ParserModel } from './parser.model'; | ||
| import * as cloneDeep from 'clone-deep'; | ||
|
|
||
| export class ParserConfigModel implements ParserModel { |
There was a problem hiding this comment.
Does this class replace SensorParserConfig? Why not just rename SensorParserConfig to this? Why would we have 2 classes that are almost the same?
There was a problem hiding this comment.
@merrimanr this was a rename what was considered as a deletion and a creation by git. If SensorParserConfig still exists that means I made a mistake.
There was a problem hiding this comment.
I don't see where SensorParserConfig was deleted in this commit.
There was a problem hiding this comment.
@merrimanr I found it. Like I said it was recognized as a delete/create by git and we added the delete as part of code cleanup later on: 7a665a6
Are you ok with this?
There was a problem hiding this comment.
I'm sorry but I think the code cleanup changes need to be applied here.
There was a problem hiding this comment.
I agreed. No problems. I pulled in the code cleanup commit.
| export class MetronAlerts { | ||
|
|
||
| public static SUCESS_MESSAGE_DISPALY_TIME = 5000; | ||
| public static SUCCESS_MESSAGE_DISPALY_TIME = 5000; |
There was a problem hiding this comment.
This is still misspelled. I think it should be SUCCESS_MESSAGE_DISPLAY_TIME?
|
+1 |
…TRON-1856-parser-aggregation-UI-Tibors-PR3
|
Thanks for merging! |
Contributor Comments
This PR is part of a larger sequence of PRs we are opening to make the reviewing process of the relatively large Parser Aggregation UI feature easier.
To see only the changes that apply to this PR, please review the last commit in the list of commits (the commit to review contains the title of the PR)
If you want to learn more about why we picked this method, please refer to the discussion thread here
Please find the full list of relating PRs below.
About this changeset
As part of this PR I'm introducing the model changes and new models required by Parser Aggregation.
(Please keep in mind this is only a subset of changes belongs to Parser Aggregation UI, therefore, you not gonna be able to test the whole function through this PR alone. Because of the same reason some unit tests might failing. The purpose of this PR is to break down and support the code review process.)
You can find the belonging Jira ticket here.
If you like to learn more about the feature and its context please check the Jira ticket about Parser Aggregation feature on the Metron Alerts UI
Previous and following PRs
PR#1 METRON-2114: [UI] Moving components to sensor parser module
PR#2 METRON-2116: [UI] Removing redundant AppConfigService
Current: PR#3 METRON-2117: [UI] Aligning models to grouping feature
PR#4 METRON-2115: [UI] Aligning UI to the parser aggregation AP
PR#5 METRON-2122: [UI] Fixing early app config access issue
PR#6 METRON-2124: [UI] Move status information and start/stop to the Aggregate level
PR#7 METRON-2125: [UI] Making changes visible in the parser list by marking changed items
PR#8 METRON-2131: Add NgRx and related dependencies
PR#9 METRON-2133: Add NgRx effects to communicate with the server
PR#10 METRON-2134: Add NgRx reducers to perform parser and group changes in the store
PR#11 METRON-2135: Add NgRx actions to trigger state changes
PR#12 METRON-2136: Add parser aggregation sidebar
PR#13 METRON-2137: Implement drag and drop mechanism and wire NgRx
PR#14 METRON-2138: Code clean up
PR#15 METRON-2139: Refactoring sensor-parser-config.component and wire NgRx !!! ONLY THIS LAST PR MENT TO BE MERGED TO THE FEATURE BRANCH !!! It should build fine on Travis and can be tested against full dev vm.
Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our Development Guidelines for the complete guide to follow for contributions.
Please refer also to our Build Verification Guidelines for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
For all changes:
For code changes:
Have you included steps to reproduce the behavior or problem that is being changed or addressed?
Have you included steps or a guide to how the change may be verified and tested manually?
Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
Have you written or updated unit tests and or integration tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
For documentation related changes:
Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via
site-book/target/site/index.html:Have you ensured that any documentation diagrams have been updated, along with their source files, using draw.io? See Metron Development Guidelines for instructions.
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that travis-ci is set up for your personal repository such that your branches are built there before submitting a pull request.