This repository has been archived by the owner on May 12, 2021. It is now read-only.
METRON-2139: Refactoring sensor-parser-config.component and wire NgRx #1430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
This was referenced May 24, 2019
This was referenced May 24, 2019
This was referenced May 24, 2019
sardell
reviewed
Jul 30, 2019
| @@ -0,0 +1,638 @@ | |||
| /** | |||
There was a problem hiding this comment.
@ruffle1986 I feel like we should break down this large reducer file into multiple files, as well as extract out the interfaces. I don't think it is necessarily an item that needs to be fixed for this PR to be accepted, but I do think it would make it easier to digest this code. What do you think?
There was a problem hiding this comment.
Good point. We can refactor it later once the feature is validated and accepted by users.
ruffle1986
force-pushed
the
METRON-2139
branch
from
4794d78
to
c670ae0
Compare
sardell
reviewed
Aug 22, 2019
| @@ -534,7 +534,11 @@ describe('sensors: selectors', () => { | |||
| expect(merged[1].status).toEqual(state.sensors.statuses.items[1]); | |||
| expect(merged[2].status).toEqual(state.sensors.statuses.items[2]); | |||
|
|
|||
| <<<<<<< HEAD | |||
There was a problem hiding this comment.
@ruffle1986 It looks like there is a merge conflict still needing to be resolved here.
11 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor Comments
Link to the original JIRA: https://issues.apache.org/jira/browse/METRON-2139
Link to Parent Feature ticket: https://issues.apache.org/jira/browse/METRON-1856
"sensor-parser-config" and "sensor-parser-config-readonly" components are responsible for displaying, creating and editing sensor data. Previously they had nothing to do with NgRx but since we're managing the state in an NgRx store, it made sense to refactor them and wire NgRx to manage the aforementioned operations.
Related commits
This PR is part of a larger sequence of PRs we are opening to make the reviewing process of the relatively large Parser Aggregation UI feature easier.
To see only the changes that apply to this PR, please review the last commit in the list of commits (the commit to review contains the title of the PR)
If you want to learn more about why we picked this method, please refer to the discussion thread here
Please find the full list of relating PRs below.
PR#1 METRON-2114: [UI] Moving components to sensor parser module
PR#2 METRON-2116: [UI] Removing redundant AppConfigService
PR#3 METRON-2117: [UI] Aligning models to grouping feature
PR#4 METRON-2115: [UI] Aligning UI to the parser aggregation AP
PR#5 METRON-2122: [UI] Fixing early app config access issue
PR#6 METRON-2124: [UI] Move status information and start/stop to the Aggregate level
PR#7 METRON-2125: [UI] Making changes visible in the parser list by marking changed items
PR#8 METRON-2131: Add NgRx and related dependencies
PR#9 METRON-2133: Add NgRx effects to communicate with the server
PR#10 METRON-2134: Add NgRx reducers to perform parser and group changes in the store
PR#11 METRON-2135: Add NgRx actions to trigger state changes
PR#12 METRON-2136: Add parser aggregation sidebar
PR#13 METRON-2137: Implement drag and drop mechanism and wire NgRx
PR#14 METRON-2138: Code clean up
CURRENT PR#15 METRON-2139: Refactoring sensor-parser-config.component and wire NgRx
Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our Development Guidelines for the complete guide to follow for contributions.
Please refer also to our Build Verification Guidelines for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
For all changes:
For code changes:
Have you included steps to reproduce the behavior or problem that is being changed or addressed?
Have you included steps or a guide to how the change may be verified and tested manually?
Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
Have you written or updated unit tests and or integration tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
For documentation related changes:
Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via
site-book/target/site/index.html:Have you ensured that any documentation diagrams have been updated, along with their source files, using draw.io? See Metron Development Guidelines for instructions.
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that travis-ci is set up for your personal repository such that your branches are built there before submitting a pull request.