Skip to content
This repository has been archived by the owner on Nov 5, 2018. It is now read-only.

Upgrade request dependency. #184

Merged
merged 1 commit into from
Feb 14, 2014
Merged

Conversation

jagoda
Copy link
Contributor

@jagoda jagoda commented Feb 14, 2014

Request 2.27.0 has a bug that breaks debugging with NODE_DEBUG. This bug is fixed in 2.28.0 and later. See request/request#659 for more info.

dscape added a commit that referenced this pull request Feb 14, 2014
@dscape dscape merged commit aeb1bb5 into apache:master Feb 14, 2014
@dscape
Copy link
Contributor

dscape commented Feb 14, 2014

published

@jagoda jagoda deleted the fix-update-request branch February 14, 2014 20:59
@jagoda
Copy link
Contributor Author

jagoda commented Feb 14, 2014

I'm not seeing anything later than 4.4.0 in npm. This expected?

@dscape
Copy link
Contributor

dscape commented Feb 14, 2014

not, not at all.

also this seems to have broke the build according to travis, double checking but that would be super lame

v4.6.0
^[[Onpm http PUT http://registry.nodejitsu.com/nano
npm http 409 http://registry.nodejitsu.com/nano
npm http GET http://registry.nodejitsu.com/nano
npm http 200 http://registry.nodejitsu.com/nano
npm http PUT http://registry.nodejitsu.com/nano
npm http 201 http://registry.nodejitsu.com/nano
+ nano@4.6.0
v4.6.1
Counting objects: 10, done.
Delta compression using up to 4 threads.
Compressing objects: 100% (8/8), done.
Writing objects: 100% (8/8), 793 bytes | 0 bytes/s, done.
Total 8 (delta 4), reused 0 (delta 0)
To git@github.com:dscape/nano.git
 * [new tag]         v4.6.0 -> v4.6.0
 * [new tag]         v4.6.1 -> v4.6.1
Total 0 (delta 0), reused 0 (delta 0)
To git@github.com:dscape/nano.git
   aeb1bb5..0f980a5  master -> master

@dscape
Copy link
Contributor

dscape commented Feb 14, 2014

it's fine, its an overly optimistic test

@dscape
Copy link
Contributor

dscape commented Feb 14, 2014

Seems to be related to the new npm architecture.

Asked @isaacs on twitter about this.

@jagoda
Copy link
Contributor Author

jagoda commented Feb 14, 2014

Looks to me like you're only publishing to the nodejitsu registry and not npmjs.org. I'm only seeing 4.4.0 as the "latest" on the npmjs website as well --> https://www.npmjs.org/package/nano

@dscape
Copy link
Contributor

dscape commented Feb 14, 2014

Looks correct.

@jagoda
Copy link
Contributor Author

jagoda commented Feb 14, 2014

Weird. This is what I see:
image

@dscape
Copy link
Contributor

dscape commented Feb 14, 2014

I really dont know. I am left wondering how many of my packages are not updated, and how many people have the same problem really.

@jagoda
Copy link
Contributor Author

jagoda commented Feb 14, 2014

Indeed. I will keep an eye on the npm discussions. Thanks for the help.

@dscape
Copy link
Contributor

dscape commented Feb 17, 2014

should be published

@jagoda
Copy link
Contributor Author

jagoda commented Feb 17, 2014

Looks good on my end -- thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants