fix failure when running with NODE_DEBUG=request, and a test for that #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Anyways, I added the stuff to silence the output, but check it for reasonable output. |
|
Thanks for the PR! |
nylen
added a commit
that referenced
this pull request
Sep 13, 2013
fix failure when running with NODE_DEBUG=request, and a test for that
christophercurrie
added a commit
to christophercurrie/azure-sdk-for-node
that referenced
this pull request
Feb 6, 2014
If NODE_DEBUG contains 'request' (to enable debugging), the currently used version of request (2.27.0) has a [bug][request-659] that causes an exception. This bug is fixed in version 2.28.0 and later. This bug is important to fix, because without it, end users that also use request in their own code cannot enable debugging for non-azure uses without breaking azure calls. [request-659]: request/request#659
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just adding a missing require from the refactor.
I can extend the test to shut up the noise to stderr and assert that something reasonable is returned, if that's of interest.