fix failure when running with NODE_DEBUG=request, and a test for that #659

Merged
merged 2 commits into from Sep 13, 2013

Projects

None yet

2 participants

@jrgm
Contributor
jrgm commented Sep 13, 2013

Just adding a missing require from the refactor.

I can extend the test to shut up the noise to stderr and assert that something reasonable is returned, if that's of interest.

@jrgm
Contributor
jrgm commented Sep 13, 2013

Anyways, I added the stuff to silence the output, but check it for reasonable output.

@nylen
Member
nylen commented Sep 13, 2013

Thanks for the PR!

@nylen nylen merged commit f88e8a5 into request:master Sep 13, 2013
@jrgm jrgm deleted the jrgm:fix-use-of-node-debug branch Sep 14, 2013
@christophercurrie christophercurrie added a commit to christophercurrie/azure-sdk-for-node that referenced this pull request Feb 6, 2014
@christophercurrie christophercurrie Upgrade request dependency to fix NODE_DEBUG issue
If NODE_DEBUG contains 'request' (to enable debugging), the currently used version of request (2.27.0) has a [bug][request-659] that causes an exception. This bug is fixed in version 2.28.0 and later.

This bug is important to fix, because without it, end users that also use request in their own code cannot enable debugging for non-azure uses without breaking azure calls.

[request-659]: request/request#659
477aca8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment