Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.2 Support #5300

Merged
merged 19 commits into from
Jan 17, 2023
Merged

PHP 8.2 Support #5300

merged 19 commits into from
Jan 17, 2023

Conversation

junichi11
Copy link
Member

@junichi11 junichi11 commented Jan 16, 2023

#4725
This is a partial support. Some features don't work.

junichi11 and others added 11 commits October 25, 2022 14:26
- #4725
- https://wiki.php.net/rfc/true-type
- Fix `UnusableTypesHintError` and CC
- Add/Fix unit tests for the Hint, the Navigator and CC
…-true-as-stand-alone-types

PHP 8.2 Support: Allow `null`, `false`, and `true` as stand-alone types
- #4725
- https://wiki.php.net/rfc/readonly_classes
- Fix the grammar file
- Add `PHP82UnhandledError`
- Add/Fix unit tests for the parser, the lexter, and the index
- #4725
- https://wiki.php.net/rfc/readonly_classes
- Fix hints for readonly classes
- Add the code template for a readonly class
- Add unit tests for hints, formatter, and CC
- https://issues.apache.org/jira/browse/NETBEANS-5599
- RFC:https://wiki.php.net/rfc/new_in_initializers
- Support for field and method access for constant (e.g. `const C = new A(); C->field; C->method();`)
- Fix the parser
- Fix PHP81UnhandledError
- #4725
- https://wiki.php.net/rfc/fetch_property_in_const_expressions
- Fix the grammar file
- Fix CC: add the readonly name property to enums
- Add/Fix unit tests for the parser and CC
…ms-in-const-expressions

PHP 8.2 Support: Fetch properties of enums in const expressions
@junichi11 junichi11 added the PHP [ci] enable extra PHP tests (php/php.editor) label Jan 16, 2023
@junichi11 junichi11 added this to the NB17 milestone Jan 16, 2023
- #4725
- https://wiki.php.net/rfc/constants_in_traits
- Fix the grammar file
- Fix `PHP82UnhandledError`
- Add/Fix unit tests for the parser, the lexer, and `IncorrectEnumHintError`
- #4725
- https://wiki.php.net/rfc/constants_in_traits
- Add trait constants to the index
- Fix the navigator
- Add unit tests for the index and the navigator
- #4725
- https://wiki.php.net/rfc/constants_in_traits
- Fix the mark occurrences and the go to declaration
- Add unit tests
- #4725
- https://wiki.php.net/rfc/dnf_types
- Fix the grammar file, `PHP82UnhandledError`, and `UnusableTypeHintError`
- Add/Fix unit tests for the parser
PHP 8.2 Support: Constants in Traits and Disjunctive Normal Form Types
@tmysik
Copy link
Member

tmysik commented Jan 17, 2023

I plan to merge this PR later today, once the checks are finished. Please, let me know if I should not do it. Thanks.

CC @junichi11 @matthiasblaesing

@junichi11
Copy link
Member Author

It should be no problem. Thanks!

@mbien
Copy link
Member

mbien commented Jan 17, 2023

restarted the failing job which is unrelated to this PR.

This branch here seems to be fairly old since I still see travis in the checks. Although it would be better to rebase it to latest master, i think it might be still ok to merge since the PHP job didn't have any changes recently (and wasn't tested on travis).

@tmysik
Copy link
Member

tmysik commented Jan 17, 2023

OK, so merging 🤞

@tmysik tmysik merged commit a97c358 into master Jan 17, 2023
@junichi11 junichi11 deleted the php82-support branch October 20, 2023 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PHP [ci] enable extra PHP tests (php/php.editor)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants