Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the Error class and the Throwable interface as completion items for exceptions [GH-7594] #7599

Merged
merged 1 commit into from
Jul 20, 2024

Conversation

@junichi11 junichi11 added the PHP [ci] enable extra PHP tests (php/php.editor) label Jul 19, 2024
@junichi11 junichi11 added this to the NB23 milestone Jul 19, 2024
…ms for exceptions [apacheGH-7594]

- apache#7594
- https://www.php.net/manual/en/language.errors.php7.php
- https://www.php.net/manual/en/class.error.php
- https://www.php.net/manual/en/class.throwable.php
- Check the `Error` class and the `Throwable` interface
- Add unit tests

Example:
```php
<?php
try {
} catch (Thro^) { // here, ^ is the caret position
}
```
@junichi11 junichi11 force-pushed the php-gh-7594-cc-throwable-error branch from f183bd8 to 89f63f0 Compare July 19, 2024 09:12
@junichi11 junichi11 requested a review from tmysik July 19, 2024 10:31
Copy link
Member

@tmysik tmysik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@junichi11 junichi11 merged commit b1a4514 into apache:master Jul 20, 2024
32 checks passed
@junichi11 junichi11 deleted the php-gh-7594-cc-throwable-error branch July 20, 2024 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PHP [ci] enable extra PHP tests (php/php.editor)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PHP] Code completion within catch(...) does not offer "throwable" or "error"
2 participants