Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PHP] Code completion within catch(...) does not offer "throwable" or "error" #7594

Closed
NReib opened this issue Jul 18, 2024 · 1 comment · Fixed by #7599
Closed

[PHP] Code completion within catch(...) does not offer "throwable" or "error" #7594

NReib opened this issue Jul 18, 2024 · 1 comment · Fixed by #7599
Assignees
@junichi11
Labels
kind:bug Bug report or fix PHP [ci] enable extra PHP tests (php/php.editor)
Milestone
NB23

Comments

@NReib
Copy link

NReib commented Jul 18, 2024 •
edited
Loading

Apache NetBeans version

Apache NetBeans 22

What happened

See example below

Language / Project Type / NetBeans Component

No response

How to reproduce

try{

} catch(throwa){ // code completion here will not offer throwable; same for error

}

Did this work correctly in an earlier version?

No / Don't know

Operating System

Mageia 8 (Linux)

JDK

javac 11.0.17

Apache NetBeans packaging

Apache NetBeans binary zip

Anything else

No response

Are you willing to submit a pull request?

No
@NReib NReib added kind:bug Bug report or fix needs:triage Requires attention from one of the committers labels Jul 18, 2024
@junichi11 junichi11 added PHP [ci] enable extra PHP tests (php/php.editor) and removed needs:triage Requires attention from one of the committers labels Jul 18, 2024
@junichi11 junichi11 self-assigned this Jul 18, 2024
@junichi11 junichi11 added this to the NB23 milestone Jul 18, 2024
@junichi11
Copy link
Member

Reproducible. Thanks.

junichi11 added a commit to junichi11/netbeans that referenced this issue Jul 19, 2024
@junichi11
Add the Error class and the Throwable interface as completion ite…
c888712 
…ms for exceptions [apacheGH-7594]

- apache#7594
- https://www.php.net/manual/en/language.errors.php7.php
- https://www.php.net/manual/en/class.error.php
- https://www.php.net/manual/en/class.throwable.php

Example:
```php
<?php
try {
} catch (Thro^) { // here, ^ is the caret position
}
```
junichi11 added a commit to junichi11/netbeans that referenced this issue Jul 19, 2024
@junichi11
Add the Error class and the Throwable interface as completion ite…
f183bd8 
…ms for exceptions [apacheGH-7594]

- apache#7594
- https://www.php.net/manual/en/language.errors.php7.php
- https://www.php.net/manual/en/class.error.php
- https://www.php.net/manual/en/class.throwable.php

Example:
```php
<?php
try {
} catch (Thro^) { // here, ^ is the caret position
}
```
@junichi11 junichi11 mentioned this issue Jul 19, 2024
Merged
@junichi11 junichi11 linked a pull request Jul 19, 2024 that will close this issue
Add the Error class and the Throwable interface as completion items for exceptions [GH-7594] #7599
Merged
junichi11 added a commit to junichi11/netbeans that referenced this issue Jul 19, 2024
@junichi11
Add the Error class and the Throwable interface as completion ite…
89f63f0 
…ms for exceptions [apacheGH-7594]

- apache#7594
- https://www.php.net/manual/en/language.errors.php7.php
- https://www.php.net/manual/en/class.error.php
- https://www.php.net/manual/en/class.throwable.php
- Check the `Error` class and the `Throwable` interface
- Add unit tests

Example:
```php
<?php
try {
} catch (Thro^) { // here, ^ is the caret position
}
```
junichi11 added a commit that referenced this issue Jul 20, 2024
@junichi11
Merge pull request #7599 from junichi11/php-gh-7594-cc-throwable-error
b1a4514 
Add the `Error` class and the `Throwable` interface as completion items for exceptions [GH-7594]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@junichi11 junichi11

Labels
kind:bug Bug report or fix PHP [ci] enable extra PHP tests (php/php.editor)
Projects
None yet
Milestone
NB23
2 participants
@junichi11 @NReib