Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libc: Implement strlcpy function #1584

Merged
merged 1 commit into from
Aug 14, 2020
Merged

libc: Implement strlcpy function #1584

merged 1 commit into from
Aug 14, 2020

Conversation

anchao
Copy link
Contributor

@anchao anchao commented Aug 14, 2020

Summary

libc: Implement strlcpy function

Reference:
http://www.delorie.com/djgpp/doc/libc/libc_763.html

Signed-off-by: chao.an anchao@xiaomi.com

Impact

Non Default is Off

Testing

api test

* Name: strlcpy
*
* Description:
* Copy src to string dst of size siz. At most siz-1 characters
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment names do not match code's names.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment names do not match code's names.

Got.

Reference:
http://www.delorie.com/djgpp/doc/libc/libc_763.html

Signed-off-by: chao.an <anchao@xiaomi.com>
Copy link
Contributor

@davids5 davids5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anchao Thank you for fixing the comments and having a Kconfig Knob! I added a statement to Impact as this is off by default.

@davids5 davids5 merged commit 7356b5a into apache:master Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants