Fix pthread cmdline issue #2872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yamt
reviewed
Feb 19, 2021
xiaoxiang781216
force-pushed
the
pthread
branch
3 times, most recently
from
4fbf251
to
01ac5c6
Compare
|
Will you consider a "pt-" prefix? |
|
Is it enough to identify pthread by <>? task/kthread doesn't quote his name by <> normally. |
|
My feeling is that before it said what it was now it does not. The prefix of |
like this: ... <pthread> 0x0x341de68c by removing "0x" from format string Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
since it's very easy to identify thread through entry pointer Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
xiaoxiang781216
force-pushed
the
pthread
branch
from
01ac5c6
to
73731fa
Compare
|
Ok, it show pt-0xyyyyyyyy now. |
davids5
approved these changes
Feb 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Before change:
After change:
Note, you can still change pthread name through pthread_setname_np, this patch just modify the default behaviour.
Impact
The content from: /proc/xxx/cmdline
Testing