libc: Make perror work without CONFIG_FILE_STREAM #4829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaoxiang781216
force-pushed
the
stdio3
branch
5 times, most recently
from
2367777
to
a00a04a
Compare
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
xiaoxiang781216
force-pushed
the
stdio3
branch
from
a00a04a
to
dea0eaf
Compare
davids5
reviewed
Nov 15, 2021
|
Let, the stdio(implicitly accept stdin/stdout/stderr) API work even the general stdio(fopen, fclose) API doesn't exist. This is the practice already used for printf: |
|
@davids5 do you have any more concern? |
davids5
approved these changes
Nov 16, 2021
|
@davids5 could you merge this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Impact
Minor
Testing
Pass CI