Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libs/libc/string: add memmem #6667

Merged
merged 1 commit into from
Jul 22, 2022
Merged

libs/libc/string: add memmem #6667

merged 1 commit into from
Jul 22, 2022

Conversation

Cynerd
Copy link
Contributor

@Cynerd Cynerd commented Jul 21, 2022

This function is the GNU extension.

Summary

Impact

Testing

Tested on custom SAME70N21 based board.

libs/libc/string/lib_memmem.c Outdated Show resolved Hide resolved
libs/libc/string/lib_memmem.c Outdated Show resolved Hide resolved
libs/libc/string/lib_memmem.c Outdated Show resolved Hide resolved
@xiaoxiang781216
Copy link
Contributor

@Cynerd let's squash these patch into one.

@pkarashchenko
Copy link
Contributor

Please fix build error

string/lib_memmem.c: In function 'memmem':
Error: string/lib_memmem.c:65:24: error: return discards 'const' qualifier from pointer target type [-Werror=discarded-qualifiers]
   65 |               return h + i;

This function is the GNU extension.
@pkarashchenko pkarashchenko merged commit 6c7f991 into apache:master Jul 22, 2022
@Cynerd Cynerd deleted the memmem branch July 23, 2022 10:28
@jerpelea jerpelea added this to To-Add in Release Notes - 11.0.0 Aug 30, 2022
@jerpelea jerpelea moved this from To-Add to Added in Release Notes - 11.0.0 Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants