Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for NXP S32K3XX MCU family and boards #6687

Merged
merged 9 commits into from
Jul 25, 2022

Conversation

PetervdPerk-NXP
Copy link
Contributor

Summary

Initial support for NXP S32K3XX MCU family including many drivers

  • UART
  • I2C
  • SPI
  • CAN
  • Ethernet
  • QSPI
  • GPIO (+ interrupt)

Add support for following boards:
S32k3X4EVB-Q257
MR-CANHUBK3 (To be released soon)

Impact

Also changes MX25RXX driver to support MX25LXX as well.
Bug fixes in net/can receiving with multiple applications.
SocketCAN add non-blocking write support

Testing

Tested on S32k3X4EVB-Q257 & MR-CANHUBK3

Note

This the first commit since we've signed the CCLA & ICLA, we're still required by company policy to include a NXP Copyright header, is this included in the correct way? Furthermore do the NOTICE and AUTHOR files have to updated and what's the policy to do so?

jarivanewijk and others added 2 commits July 22, 2022 11:34
Co-authored-by: Peter van der Perk <peter.vanderperk@nxp.com>
Co-authored-by: Peter van der Perk <peter.vanderperk@nxp.com>
jarivanewijk and others added 3 commits July 22, 2022 13:04
Co-authored-by: Peter van der Perk <peter.vanderperk@nxp.com>
Co-authored-by: Peter van der Perk <peter.vanderperk@nxp.com>
Co-authored-by: Peter van der Perk <peter.vanderperk@nxp.com>
arch/arm/src/s32k3xx/hardware/s32k3xx_dmamux.h Outdated Show resolved Hide resolved
arch/arm/src/s32k3xx/hardware/s32k3xx_edma.h Outdated Show resolved Hide resolved
arch/arm/src/s32k3xx/hardware/s32k3xx_edma.h Outdated Show resolved Hide resolved
arch/arm/src/s32k3xx/hardware/s32k3xx_edma.h Outdated Show resolved Hide resolved
arch/arm/src/s32k3xx/hardware/s32k3xx_edma.h Outdated Show resolved Hide resolved
drivers/mtd/mx25rxx.c Outdated Show resolved Hide resolved
drivers/mtd/mx25rxx.c Outdated Show resolved Hide resolved
boards/arm/s32k3xx/s32k344evb/src/s32k3xx_userleds.c Outdated Show resolved Hide resolved
boards/arm/s32k3xx/s32k344evb/src/s32k3xx_appinit.c Outdated Show resolved Hide resolved
Co-authored-by: Jari van Ewijk <jari.vanewijk@nxp.com>
@davids5
Copy link
Contributor

davids5 commented Jul 22, 2022

@PetervdPerk-NXP Are those Doxygen tags?

Deoxygen Information. NuttX does not use Deoxygen for documentation and no file should contain Doxygen tags or Doxygen style comments.

@PetervdPerk-NXP
Copy link
Contributor Author

@PetervdPerk-NXP Are those Doxygen tags?

Deoxygen Information. NuttX does not use Deoxygen for documentation and no file should contain Doxygen tags or Doxygen style comments.

Thanks there were some files using wrong comment style indeed, I've fixed them.

arch/arm/src/s32k3xx/hardware/s32k3xx_edma.h Outdated Show resolved Hide resolved
arch/arm/src/s32k3xx/hardware/s32k3xx_edma.h Outdated Show resolved Hide resolved
arch/arm/src/s32k3xx/hardware/s32k3xx_emac.h Show resolved Hide resolved
arch/arm/src/s32k3xx/hardware/s32k3xx_emios.h Outdated Show resolved Hide resolved
arch/arm/src/s32k3xx/hardware/s32k3xx_flexcan.h Outdated Show resolved Hide resolved
arch/arm/src/s32k3xx/hardware/s32k3xx_qspi.h Outdated Show resolved Hide resolved
arch/arm/src/s32k3xx/hardware/s32k3xx_qspi.h Outdated Show resolved Hide resolved
arch/arm/src/s32k3xx/hardware/s32k3xx_virtwrapper.h Outdated Show resolved Hide resolved
arch/arm/src/s32k3xx/s32k3xx_edma.c Show resolved Hide resolved
arch/arm/src/s32k3xx/s32k3xx_edma.c Outdated Show resolved Hide resolved
Copy link
Contributor

@pkarashchenko pkarashchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment. Other parts LGTM!

arch/arm/src/s32k3xx/hardware/s32k3xx_qspi.h Outdated Show resolved Hide resolved
@davids5 davids5 self-requested a review July 25, 2022 12:26
Copy link
Contributor

@davids5 davids5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's re-kick CI.

@davids5 davids5 closed this Jul 25, 2022
@davids5 davids5 reopened this Jul 25, 2022
@xiaoxiang781216 xiaoxiang781216 merged commit 9e7e45d into apache:master Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants