Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arch/arm/stm32h7: multiple fixes for stm32h7 flash interface #7401

Merged
merged 1 commit into from
Oct 25, 2022

Conversation

pkarashchenko
Copy link
Contributor

@pkarashchenko pkarashchenko commented Oct 23, 2022

Summary

This PR contain few fixes for stm32h7 flash interface:

  • Fix cache invalidation before reading flash data after flash erase operation
  • Fix stm32h7_israngeerased operation to use the correct address on byte read
  • Fix error checking in stm32h7_israngeerased
  • Replace exclusive semaphore with mutex
  • Fix few style issues

Impact

Bug fix

Testing

Pass CI

@xiaoxiang781216
Copy link
Contributor

please rebase the change to fix the ci error.

Signed-off-by: Petro Karashchenko <petro.karashchenko@gmail.com>
@xiaoxiang781216
Copy link
Contributor

@tito97sp should we merge this patch instead yours(#7397)?

@tito97sp
Copy link
Contributor

tito97sp commented Oct 25, 2022

@tito97sp should we merge this patch instead yours(#7397)?

@xiaoxiang781216 Yes. This PR substitutes mine.

@pkarashchenko
Copy link
Contributor Author

@tito97sp should we merge this patch instead yours(#7397)?

@xiaoxiang781216 Yes. This PR substitutes mine.

Could you please approve the PR if all the tests pass at your end?

@tito97sp
Copy link
Contributor

@tito97sp should we merge this patch instead yours(#7397)?

@xiaoxiang781216 Yes. This PR substitutes mine.

Could you please approve the PR if all the tests pass at your end?

I'm on it

@tito97sp
Copy link
Contributor

tito97sp commented Oct 25, 2022

Test passed on local setup. Ready to merge @pkarashchenko @xiaoxiang781216

@davids5 davids5 merged commit 4c71075 into apache:master Oct 25, 2022
@pkarashchenko pkarashchenko deleted the stm32h7_flash_fix branch August 20, 2023 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants