Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

layers: madsim support #1871

Closed
SkyFan2002 opened this issue Apr 7, 2023 · 3 comments · Fixed by #2006
Closed

layers: madsim support #1871

SkyFan2002 opened this issue Apr 7, 2023 · 3 comments · Fixed by #2006

Comments

@SkyFan2002
Copy link
Contributor

madsim-rs/madsim#122
@wangrunji0408 wangrunji0408 mentioned this issue Apr 10, 2023
Closed
@wangrunji0408
Copy link

Coming from #1893.
Given that there's already an abstract layer in OpenDAL, I suggest building a simulator directly for the interface semantics, rather than using madsim-aws-sdk-s3 as a backend. This idea aligns with @Xuanwo's suggestion: "the sim feature be implemented as a separate layer or service".

@Xuanwo Xuanwo mentioned this issue Apr 10, 2023
Open
@Xuanwo
Copy link
Member

Xuanwo commented Apr 10, 2023

After some discussion with @SkyFan2002, we found it's better to implement this feature as a MadsimLayer so all service can be tested.

@SkyFan2002
Copy link
Contributor Author

SkyFan2002 commented Apr 11, 2023 •
edited

A rough plan:

  1. overall framework
  • MadsimLayer
  • a server that simulates the service
  • use madsim's network API to connect them
  • simple tests like write() and read()
  1. continue to improve
  • support for more interfaces
  • inject failures
  • ...

@Xuanwo Xuanwo changed the title feat: madsim support layer: madsim support Apr 14, 2023
@Xuanwo Xuanwo changed the title layer: madsim support layers: madsim support Apr 14, 2023
@Xuanwo Xuanwo mentioned this issue Apr 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(layer): add madsim layer SkyFan2002/incubator-opendal
3 participants
@Xuanwo @wangrunji0408 @SkyFan2002