Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

idea: Allow list path that not ends with / #2762

Closed
Xuanwo opened this issue Aug 2, 2023 · 5 comments · Fixed by #3243
Closed

idea: Allow list path that not ends with / #2762

Xuanwo opened this issue Aug 2, 2023 · 5 comments · Fixed by #3243

Comments

@Xuanwo
Copy link
Member

Xuanwo commented Aug 2, 2023

Many OpenDAL users have been bothered by a long-term issue where the path used for lists must end with a /. So I think it's a good idea to loosen this restriction, and allow users to list any path.

Given file tree like:

/abc/
/abc/def
/abc/xyz/

The behavior will be like the following:

path delimiter output
/abc "" /abc/def, /abc/xyz/
/abc "/" /abc/def, /abc/xyz/
/abc/ "" /abc/def, /abc/xyz/
/abc/ "/" /abc/def, /abc/xyz/
/ab "" /abc/, /abc/def, /abc/xyz/
/ab "/" /abc/
/ab/ ""
/ab/ "/"

The behavior will mostly the same with before.

@G-XD
Copy link
Contributor

G-XD commented Aug 31, 2023

I want try to do this task, can it be assigned to be? And is this issue a duplicate of #2073?

@Xuanwo
Copy link
Member Author

Xuanwo commented Aug 31, 2023

I want try to do this task, can it be assigned to be?

Thanks a lot! This issue will change our public API so it requires an RFC first.

And is this issue a duplicate of #2073?

Yep!

@Xuanwo
Copy link
Member Author

Xuanwo commented Oct 7, 2023

Hi, @G-XD, are you sill working on this issue?

@G-XD
Copy link
Contributor

G-XD commented Oct 7, 2023

Hi, @G-XD, are you sill working on this issue?

Sorry I haven't been following this for a few days. But please feel free to ask if you need anything.

@Xuanwo
Copy link
Member Author

Xuanwo commented Oct 7, 2023

Sorry I haven't been following this for a few days. But please feel free to ask if you need anything.

I will start an RFC for this and welcome to take part in the discussion!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants