Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vcpkg] Add 2.0.0 to vcpkg versions #1848

Closed
deshanxiao opened this issue Mar 16, 2024 · 6 comments
Closed

[Vcpkg] Add 2.0.0 to vcpkg versions #1848

deshanxiao opened this issue Mar 16, 2024 · 6 comments

Comments

@deshanxiao
Copy link
Contributor

https://github.com/microsoft/vcpkg/blob/master/versions/o-/orc.json

@dongjoon-hyun
Copy link
Member

+1 for that.

@dongjoon-hyun
Copy link
Member

Gentle ping, @deshanxiao .

@deshanxiao
Copy link
Contributor Author

deshanxiao commented Apr 1, 2024

Hi @dongjoon-hyun I add a PR here:
microsoft/vcpkg#37880

In ORC 2.0.1, I have a plan to remove patch file in vcpkg like conan. This need a minor change in ORC repo also.

@dongjoon-hyun
Copy link
Member

Thank you. Got it.

@deshanxiao
Copy link
Contributor Author

Issue resolved by microsoft/vcpkg#37880

@dongjoon-hyun
Copy link
Member

Nice! Thank you again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants