Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings / deprecations etc. in relation to former Akka 2.5 support #57

Open
jrudolph opened this issue Feb 14, 2023 · 2 comments
Open
Milestone

Comments

@jrudolph
Copy link
Contributor

Some things could not properly fixed to keep compatibility with Akka 2.5. Since we don't care anymore about 2.5, we can clean things up.

  • stream cancellation handling (getting causes in onDownstreamFinish)
@pjfanning pjfanning added this to the 1.0.0 milestone Feb 14, 2023
@spangaer
Copy link
Contributor

Mhaha, ghosts from the past.

Does sound more like a 1.1 thing though?

@mdedetrich
Copy link
Contributor

mdedetrich commented Feb 15, 2023

Does sound more like a 1.1 thing though?

Yes, these changes should be in 1.1. Stuff like parboiled is an exception because we are not expecting any behaviour change but this would technically be a behaviour change (even if its an improvement).

I will adjust milestone.

@mdedetrich mdedetrich modified the milestones: 1.0.0, 1.1.0 Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants