Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support building with Windows #829

Open
Tracked by #1052
pjfanning opened this issue Dec 3, 2023 · 10 comments
Open
Tracked by #1052

Support building with Windows #829

pjfanning opened this issue Dec 3, 2023 · 10 comments
Labels
help wanted Extra attention is needed

Comments

@pjfanning
Copy link
Contributor

We have had reports of issues building (from source) with Windows. I don't have access to a Windows machine to verify.

@pjfanning pjfanning added the help wanted Extra attention is needed label Dec 3, 2023
@laglangyue
Copy link
Contributor

I have a windows compute,what can I do, just compile?

@pjfanning
Copy link
Contributor Author

https://github.com/apache/incubator-pekko/#building-from-source has the build instrucations.

it would be good to at least get sbt compile tested

@He-Pin
Copy link
Member

He-Pin commented Dec 8, 2023

I'm using windows, I think it's OK, let me check and report back, it works.
image

@laglangyue
Copy link
Contributor

I also test with sbt compile on win 10,and I haven't found any errors.

@Roiocam
Copy link
Member

Roiocam commented Jan 24, 2024

Related on #986? could you give more information about this?

@mdedetrich
Copy link
Contributor

mdedetrich commented Jan 24, 2024

Related on #986? could you give more information about this?

Its unrelated to #986 . The context of this issue is that at one point in time someone was verifying the Pekko project as part of the release process and they were doing it on the Windows machine and there were problems with that.

It could be that the person was testing the src distribution (i.e not from git repo) which is why it didn't work on windows, but this is speculation. I would actually close this ticket since it isn't specified properly, @pjfanning wdyt?

@Roiocam
Copy link
Member

Roiocam commented Jan 24, 2024

Related on #986? could you give more information about this?

Its unrelated to #986 . The context of this issue is that at one point in time someone was verifying the Pekko project as part of the release process and they were doing it on the Windows machine and there were problems with that.

It could be that the person was testing the src distribution (i.e not from git repo) which is why it didn't work on windows, but this is speculation. I would actually close this ticket since it isn't specified properly, @pjfanning wdyt?

I know, I'm just trying to throw a stone and make some waves.

I have encountered issues affected by line separators multiple times in my career, especially when developers cross-use Windows and Unix-like systems.

It would be better to have more context information to help advance this issue and resolve it.

@mdedetrich
Copy link
Contributor

I know, I'm just trying to throw a stone and make some waves.

I have encountered issues affected by line separators multiple times in my career, especially when developers cross-use Windows and Unix-like systems.

It would be better to have more context information to help advance this issue and resolve it.

The src distributions are listed here so I guess you can try downloading the latest pekko src distribution and seeing if it compiles/test passes on Windows

@He-Pin
Copy link
Member

He-Pin commented Jan 24, 2024

I'm developing on windows 11, I think it works now. but a window/ARM(where concurrency code matters) CI should be nice.

@mdedetrich
Copy link
Contributor

I'm developing on windows 11, I think it works now. but a window/ARM(where concurrency code matters) CI should be nice.

The critical distinction here is the src distribution which tbh I would be surprised if anyone developed with, let alone download and used outside of voting for a Pekko release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

5 participants