Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHOENIX-1674 Snapshot isolation transaction support through Tephra #131

Closed
wants to merge 2 commits into from

Conversation

twdsilva
Copy link
Contributor

PR without tests.

@JamesRTaylor @samarthjain

@JamesRTaylor
Copy link
Contributor

FYI, @twdsilva broke this up into two separate pulls because GitHub wasn't show the diff for all files. The tests are over in #132. Both this pull and that one will be committed together - this is just to make the review easier.

@@ -51,6 +51,7 @@
import org.apache.phoenix.iterate.SequenceResultIterator;
import org.apache.phoenix.iterate.SpoolingResultIterator;
import org.apache.phoenix.iterate.UngroupedAggregatingResultIterator;
import org.apache.phoenix.jdbc.PhoenixStatement.Operation;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there no other change other than this import in the file? Probably should be reverted then?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will revert this file.

@twdsilva twdsilva closed this Nov 23, 2015
@twdsilva twdsilva deleted the txn_review branch July 21, 2016 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants