Skip to content

Conversation

@jpisaac
Copy link
Contributor

@jpisaac jpisaac commented May 6, 2021

No description provided.

@stoty
Copy link
Contributor

stoty commented May 6, 2021

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 8s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 25 new or modified test files.
_ master Compile Tests _
+1 💚 mvninstall 17m 20s master passed
+0 hbaserecompile 24m 32s HBase recompiled.
+1 💚 compile 0m 32s master passed
+1 💚 checkstyle 0m 31s master passed
+1 💚 javadoc 0m 20s master passed
+0 🆗 spotbugs 0m 54s phoenix-pherf in master has 51 extant spotbugs warnings.
_ Patch Compile Tests _
-1 ❌ mvninstall 9m 44s root in the patch failed.
+0 hbaserecompile 17m 42s HBase recompiled.
+1 💚 compile 0m 32s the patch passed
+1 💚 javac 0m 32s the patch passed
-1 ❌ checkstyle 0m 36s phoenix-pherf: The patch generated 532 new + 758 unchanged - 284 fixed = 1290 total (was 1042)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 8s The patch has no ill-formed XML file.
-1 ❌ javadoc 0m 19s phoenix-pherf generated 25 new + 33 unchanged - 24 fixed = 58 total (was 57)
-1 ❌ spotbugs 1m 7s phoenix-pherf generated 12 new + 42 unchanged - 9 fixed = 54 total (was 51)
_ Other Tests _
-1 ❌ unit 9m 34s phoenix-pherf in the patch failed.
+1 💚 asflicense 0m 13s The patch does not generate ASF License warnings.
58m 36s
Reason Tests
FindBugs module:phoenix-pherf
Possible null pointer dereference in org.apache.phoenix.pherf.workload.mt.handlers.RendezvousingWorkHandler.onEvent(BaseLoadEventGenerator$TenantOperationEvent) due to return value of called method Dereferenced at RendezvousingWorkHandler.java:org.apache.phoenix.pherf.workload.mt.handlers.RendezvousingWorkHandler.onEvent(BaseLoadEventGenerator$TenantOperationEvent) due to return value of called method Dereferenced at RendezvousingWorkHandler.java:[line 76]
Return value of org.apache.phoenix.pherf.workload.mt.operations.TenantOperationFactory.getPhoenixUtil() ignored, but method has no side effect At RendezvousingWorkHandler.java:but method has no side effect At RendezvousingWorkHandler.java:[line 83]
Possible null pointer dereference in org.apache.phoenix.pherf.workload.mt.handlers.TenantOperationWorkHandler.onEvent(BaseLoadEventGenerator$TenantOperationEvent) due to return value of called method Dereferenced at TenantOperationWorkHandler.java:org.apache.phoenix.pherf.workload.mt.handlers.TenantOperationWorkHandler.onEvent(BaseLoadEventGenerator$TenantOperationEvent) due to return value of called method Dereferenced at TenantOperationWorkHandler.java:[line 65]
Return value of org.apache.phoenix.pherf.workload.mt.operations.TenantOperationFactory.getPhoenixUtil() ignored, but method has no side effect At TenantOperationWorkHandler.java:but method has no side effect At TenantOperationWorkHandler.java:[line 67]
input must be non-null but is marked as nullable At IdleTimeOperationSupplier.java:is marked as nullable At IdleTimeOperationSupplier.java:[lines 51-74]
input must be non-null but is marked as nullable At PreScenarioOperationSupplier.java:is marked as nullable At PreScenarioOperationSupplier.java:[lines 51-85]
A prepared statement is generated from a nonconstant String in org.apache.phoenix.pherf.workload.mt.operations.PreScenarioOperationSupplier$1.apply(TenantOperationInfo) At PreScenarioOperationSupplier.java:from a nonconstant String in org.apache.phoenix.pherf.workload.mt.operations.PreScenarioOperationSupplier$1.apply(TenantOperationInfo) At PreScenarioOperationSupplier.java:[line 74]
input must be non-null but is marked as nullable At QueryOperationSupplier.java:is marked as nullable At QueryOperationSupplier.java:[lines 54-94]
Impossible cast from RuntimeException to java.sql.SQLException in org.apache.phoenix.pherf.workload.mt.operations.TenantOperationFactory.executePreRunOpsForTenant(TenantOperationFactory$TenantView, TenantOperationInfo) At TenantOperationFactory.java:java.sql.SQLException in org.apache.phoenix.pherf.workload.mt.operations.TenantOperationFactory.executePreRunOpsForTenant(TenantOperationFactory$TenantView, TenantOperationInfo) At TenantOperationFactory.java:[line 354]
input must be non-null but is marked as nullable At UpsertOperationSupplier.java:is marked as nullable At UpsertOperationSupplier.java:[lines 58-161]
org.apache.phoenix.pherf.workload.mt.operations.UpsertOperationSupplier$1.apply(TenantOperationInfo) may fail to clean up java.sql.Statement Obligation to clean up resource created at UpsertOperationSupplier.java:up java.sql.Statement Obligation to clean up resource created at UpsertOperationSupplier.java:[line 107] is not discharged
input must be non-null but is marked as nullable At UserDefinedOperationSupplier.java:is marked as nullable At UserDefinedOperationSupplier.java:[lines 43-47]
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1226/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #1226
Optional Tests dupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile xml
uname Linux efc0edbaa741 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev/phoenix-personality.sh
git revision master / 5265164
Default Java Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
mvninstall https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1226/1/artifact/yetus-general-check/output/patch-mvninstall-root.txt
checkstyle https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1226/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-pherf.txt
javadoc https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1226/1/artifact/yetus-general-check/output/diff-javadoc-javadoc-phoenix-pherf.txt
spotbugs https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1226/1/artifact/yetus-general-check/output/new-spotbugs-phoenix-pherf.html
unit https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1226/1/artifact/yetus-general-check/output/patch-unit-phoenix-pherf.txt
Test Results https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1226/1/testReport/
Max. process+thread count 2328 (vs. ulimit of 30000)
modules C: phoenix-pherf U: phoenix-pherf
Console output https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1226/1/console
versions git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@jpisaac jpisaac force-pushed the PHOENIX-6432-master branch from a5874d0 to 3cd5870 Compare May 7, 2021 00:22
@stoty
Copy link
Contributor

stoty commented May 7, 2021

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 10s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 25 new or modified test files.
_ master Compile Tests _
+1 💚 mvninstall 17m 4s master passed
+0 hbaserecompile 24m 33s HBase recompiled.
+1 💚 compile 0m 32s master passed
+1 💚 checkstyle 0m 31s master passed
+1 💚 javadoc 0m 21s master passed
+0 🆗 spotbugs 0m 55s phoenix-pherf in master has 51 extant spotbugs warnings.
_ Patch Compile Tests _
+1 💚 mvninstall 9m 58s the patch passed
+0 hbaserecompile 18m 0s HBase recompiled.
+1 💚 compile 0m 34s the patch passed
+1 💚 javac 0m 34s the patch passed
-1 ❌ checkstyle 0m 36s phoenix-pherf: The patch generated 533 new + 757 unchanged - 285 fixed = 1290 total (was 1042)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 10s The patch has no ill-formed XML file.
-1 ❌ javadoc 0m 19s phoenix-pherf generated 25 new + 33 unchanged - 24 fixed = 58 total (was 57)
-1 ❌ spotbugs 1m 6s phoenix-pherf generated 12 new + 42 unchanged - 9 fixed = 54 total (was 51)
_ Other Tests _
+1 💚 unit 9m 44s phoenix-pherf in the patch passed.
+1 💚 asflicense 0m 13s The patch does not generate ASF License warnings.
59m 4s
Reason Tests
FindBugs module:phoenix-pherf
Possible null pointer dereference in org.apache.phoenix.pherf.workload.mt.handlers.RendezvousingWorkHandler.onEvent(BaseLoadEventGenerator$TenantOperationEvent) due to return value of called method Dereferenced at RendezvousingWorkHandler.java:org.apache.phoenix.pherf.workload.mt.handlers.RendezvousingWorkHandler.onEvent(BaseLoadEventGenerator$TenantOperationEvent) due to return value of called method Dereferenced at RendezvousingWorkHandler.java:[line 76]
Return value of org.apache.phoenix.pherf.workload.mt.operations.TenantOperationFactory.getPhoenixUtil() ignored, but method has no side effect At RendezvousingWorkHandler.java:but method has no side effect At RendezvousingWorkHandler.java:[line 83]
Possible null pointer dereference in org.apache.phoenix.pherf.workload.mt.handlers.TenantOperationWorkHandler.onEvent(BaseLoadEventGenerator$TenantOperationEvent) due to return value of called method Dereferenced at TenantOperationWorkHandler.java:org.apache.phoenix.pherf.workload.mt.handlers.TenantOperationWorkHandler.onEvent(BaseLoadEventGenerator$TenantOperationEvent) due to return value of called method Dereferenced at TenantOperationWorkHandler.java:[line 65]
Return value of org.apache.phoenix.pherf.workload.mt.operations.TenantOperationFactory.getPhoenixUtil() ignored, but method has no side effect At TenantOperationWorkHandler.java:but method has no side effect At TenantOperationWorkHandler.java:[line 67]
input must be non-null but is marked as nullable At IdleTimeOperationSupplier.java:is marked as nullable At IdleTimeOperationSupplier.java:[lines 51-74]
input must be non-null but is marked as nullable At PreScenarioOperationSupplier.java:is marked as nullable At PreScenarioOperationSupplier.java:[lines 51-85]
A prepared statement is generated from a nonconstant String in org.apache.phoenix.pherf.workload.mt.operations.PreScenarioOperationSupplier$1.apply(TenantOperationInfo) At PreScenarioOperationSupplier.java:from a nonconstant String in org.apache.phoenix.pherf.workload.mt.operations.PreScenarioOperationSupplier$1.apply(TenantOperationInfo) At PreScenarioOperationSupplier.java:[line 74]
input must be non-null but is marked as nullable At QueryOperationSupplier.java:is marked as nullable At QueryOperationSupplier.java:[lines 54-94]
Impossible cast from RuntimeException to java.sql.SQLException in org.apache.phoenix.pherf.workload.mt.operations.TenantOperationFactory.executePreRunOpsForTenant(TenantOperationFactory$TenantView, TenantOperationInfo) At TenantOperationFactory.java:java.sql.SQLException in org.apache.phoenix.pherf.workload.mt.operations.TenantOperationFactory.executePreRunOpsForTenant(TenantOperationFactory$TenantView, TenantOperationInfo) At TenantOperationFactory.java:[line 354]
input must be non-null but is marked as nullable At UpsertOperationSupplier.java:is marked as nullable At UpsertOperationSupplier.java:[lines 58-161]
org.apache.phoenix.pherf.workload.mt.operations.UpsertOperationSupplier$1.apply(TenantOperationInfo) may fail to clean up java.sql.Statement Obligation to clean up resource created at UpsertOperationSupplier.java:up java.sql.Statement Obligation to clean up resource created at UpsertOperationSupplier.java:[line 107] is not discharged
input must be non-null but is marked as nullable At UserDefinedOperationSupplier.java:is marked as nullable At UserDefinedOperationSupplier.java:[lines 43-47]
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1226/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #1226
Optional Tests dupname asflicense javac javadoc unit xml compile spotbugs hbaserebuild hbaseanti checkstyle
uname Linux dd475f21660b 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev/phoenix-personality.sh
git revision master / 5265164
Default Java Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstyle https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1226/2/artifact/yetus-general-check/output/diff-checkstyle-phoenix-pherf.txt
javadoc https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1226/2/artifact/yetus-general-check/output/diff-javadoc-javadoc-phoenix-pherf.txt
spotbugs https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1226/2/artifact/yetus-general-check/output/new-spotbugs-phoenix-pherf.html
Test Results https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1226/2/testReport/
Max. process+thread count 2332 (vs. ulimit of 30000)
modules C: phoenix-pherf U: phoenix-pherf
Console output https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1226/2/console
versions git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@yanxinyi yanxinyi merged commit 3dcf95d into apache:master May 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants