Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build images with deps versions #19

Merged
merged 12 commits into from
Oct 7, 2022

Conversation

merlimat
Copy link
Contributor

@merlimat merlimat commented Oct 6, 2022

Motivation

Since the dependencies are getting statically linked into the binary artifacts that we release, we need to have a good/easy way to upgrade the versions of such dependencies and make sure they are consistent for all the different builds.

Modifications

  1. Use a single dependencies.yaml file to declare the dependencies
  2. The versions are then converted to variable inside the Dockerfiles
  3. Create (and cache) the Docker images used for building in the Github actions job

@merlimat merlimat added this to the 3.0.0 milestone Oct 6, 2022
@merlimat merlimat self-assigned this Oct 6, 2022
Copy link
Contributor

@BewareMyPower BewareMyPower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The snappy tar file downloaded is <version>.tar.gz.

pkg/deb/Dockerfile Outdated Show resolved Hide resolved
pkg/apk/Dockerfile Outdated Show resolved Hide resolved
pkg/rpm/Dockerfile Outdated Show resolved Hide resolved
Co-authored-by: Yunze Xu <xyzinfernity@163.com>
@merlimat merlimat merged commit 778fcba into apache:main Oct 7, 2022
@merlimat merlimat deleted the build-images-with-deps-versions branch October 7, 2022 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants