[Issue 1021][client] FIX: use maphash instead of crypto/sha256 for hash function of hashmap in Schema.hash() #1022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I saw the seed is random. so theres a method needed to fix the seed. |
bpereto
changed the title
bpereto
changed the title
|
Added a static seed with its ready from my side. |
bpereto
force-pushed
the
fix-schema-hash
branch
3 times, most recently
from
e6fbaa3
to
2615403
Compare
…p in Schema.hash() - replace sha256 hash function with hash/maphash - use uint64 (expected from maphash) as schema cache hashmap key - init static seed as it is random generated
tisonkun
approved these changes
May 31, 2023
yes, no changes to the schema itself, just the hash method to get a key for the local hashmap struct to update or access the cached schema. |
|
Merging... |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use golang/hash/maphash instead of crypto/sha256 for hash function of hashmap in Schema.hash()
as the hash function is used for determining the hash key, it is safe to use a non-cryptographic function.
Fixes #1021
Motivation
Improve performance of the SchemaCache by replacing the cryptographic hash function.
Modifications
Replaced the crypto/sha256 with golang/hash/maphash function.
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation