Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue 725][Dependencies] Upgrade beefsack/go-rate #735

Merged
merged 1 commit into from Feb 22, 2022

Conversation

shubham1172
Copy link
Contributor

@shubham1172 shubham1172 commented Feb 22, 2022

Signed-off-by: Shubham Sharma shubhash@microsoft.com

Fixes #725

Motivation

This PR will enable pulsar-client-go to be a compliant library. One of its dependencies was not compliant with OSS licensing requirements earlier, and this PR upgrades to the latest version of it, which has a MIT license.

Modifications

Ran the following commands

go get github.com/beefsack/go-rate@latest
go mod tidy

Verifying this change

  • Make sure that the change passes the CI checks.

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): yes
  • The public API: no
  • The schema: no
  • The default values of configurations: no
  • The wire protocol: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable
  • If a feature is not applicable for documentation, explain why? only dependency upgrade
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation not applicable

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
@wolfstudy wolfstudy added this to the v0.9.0 milestone Feb 22, 2022
@wolfstudy wolfstudy self-requested a review February 22, 2022 08:36
Copy link
Member

@wolfstudy wolfstudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, good jobs!!

@wolfstudy wolfstudy merged commit 128d8ea into apache:master Feb 22, 2022
freeznet pushed a commit that referenced this pull request Mar 8, 2022
Fixes #725

### Motivation

This PR will enable pulsar-client-go to be a compliant library. One of its dependencies was not compliant with OSS licensing requirements earlier, and this PR upgrades to the latest version of it, which has a MIT license.

### Modifications

Ran the following commands
```bash
go get github.com/beefsack/go-rate@latest
go mod tidy
```

### Verifying this change

- [x] Make sure that the change passes the CI checks.
@freeznet freeznet modified the milestones: v0.9.0, v0.8.1 Mar 8, 2022
nodece pushed a commit that referenced this pull request Sep 6, 2022
…ontent (#831)

* Upgrade beefsack/go-rate (#735)

Fixes #725

### Motivation

This PR will enable pulsar-client-go to be a compliant library. One of its dependencies was not compliant with OSS licensing requirements earlier, and this PR upgrades to the latest version of it, which has a MIT license.

### Modifications

Ran the following commands
```bash
go get github.com/beefsack/go-rate@latest
go mod tidy
```

### Verifying this change

- [x] Make sure that the change passes the CI checks.

* Upgrade prometheus client to 1.11.1 (#738)

* remove redundant "[]" pair in the head and tail of log content

Co-authored-by: Shubham Sharma <shubhash@microsoft.com>
Co-authored-by: Nicolò Boschi <boschi1997@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade beefsack/go-rate
3 participants