-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: upgrade deps for building on modern machine #513
Conversation
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Co-authored-by: Nicolò Boschi <boschi1997@gmail.com>
Pending to merge... I'm going to prepare a 0.4.0 release candidate tomorrow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -18,8 +18,8 @@ plugins { | |||
} | |||
|
|||
node { | |||
version = '10.14.1' | |||
npmVersion = '6.4.1' | |||
version = '16.19.1' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or use the 18.16 LTS version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I may do it after 0.4.0 released or we find further blocker to fix :D
Merging... |
Spot when preparing 0.4.0-rc...
Verifying this change
./gradlew build
checks.