Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: upgrade deps for building on modern machine #513

Merged
merged 7 commits into from
Apr 18, 2023

Conversation

tisonkun
Copy link
Member

@tisonkun tisonkun commented Apr 17, 2023

Spot when preparing 0.4.0-rc...

Verifying this change

  • Make sure that the change passes the ./gradlew build checks.

Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun tisonkun marked this pull request as ready for review April 17, 2023 07:38
Signed-off-by: tison <wander4096@gmail.com>
README.md Outdated Show resolved Hide resolved
Co-authored-by: Nicolò Boschi <boschi1997@gmail.com>
@tisonkun
Copy link
Member Author

Pending to merge...

I'm going to prepare a 0.4.0 release candidate tomorrow.

Copy link
Member

@nodece nodece left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -18,8 +18,8 @@ plugins {
}

node {
version = '10.14.1'
npmVersion = '6.4.1'
version = '16.19.1'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or use the 18.16 LTS version?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I may do it after 0.4.0 released or we find further blocker to fix :D

@tisonkun
Copy link
Member Author

Merging...

@tisonkun tisonkun merged commit c04fa81 into apache:master Apr 18, 2023
@tisonkun tisonkun deleted the build branch April 18, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants