Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve topic lookup for topics that have high number of partitions #1088

Closed
sijie opened this issue Jan 21, 2018 · 6 comments
Closed

Improve topic lookup for topics that have high number of partitions #1088

sijie opened this issue Jan 21, 2018 · 6 comments
Labels
area/client lifecycle/stale type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages

Comments

@sijie
Copy link
Member

sijie commented Jan 21, 2018

Problem

Currently the client looks up topic location per topic partition. This would result in quite a lot of topic lookup requests when a topic has many partitions. It would be great to batch the topic location lookup requests, so a client doesn't have to send that many lookup requests.

@sijie sijie added type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages area/client labels Jan 21, 2018
@MarvinCai
Copy link
Contributor

If no one is actively working on this issue I'll take it up.

@sijie
Copy link
Member Author

sijie commented Mar 30, 2019

I am not aware of anyone working on this. so feel free to pick it up

@MarvinCai
Copy link
Contributor

Look into the code a bit and identify some places where change need to be made, also add proposed update to protobuf in the a doc.
@sijie can you please take a look and see if I'm on the right track? Feel free to leave any comment in the doc or in this thread. Thanks!

@sijie
Copy link
Member Author

sijie commented Apr 3, 2019

@MarvinCai awesome! since it is proposing a new set of wire commands, it would be good to finalize your google doc into a PIP and share it to dev@ mailing list. loop @jiazhai in since he did look into this area before he would have more context in helping you finalizing a good proposal so that you can share with dev@ mailing list.

@jiazhai
Copy link
Member

jiazhai commented Apr 3, 2019

glad to help

@tisonkun
Copy link
Member

tisonkun commented Dec 6, 2022

Closed as stale. Please open a new issue if it's still relevant to the maintained versions.

@tisonkun tisonkun closed this as not planned Won't fix, can't repro, duplicate, stale Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/client lifecycle/stale type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
Projects
None yet
Development

No branches or pull requests

5 participants