Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[improve][doc] Add a limitation for key_shared subscription type #15709

Merged
merged 5 commits into from
Sep 29, 2022
Merged

[improve][doc] Add a limitation for key_shared subscription type #15709

merged 5 commits into from
Sep 29, 2022

Conversation

momo-jun
Copy link
Contributor

@momo-jun momo-jun commented May 23, 2022 •
edited
Loading

Fixes #15705

Modifications

  1. Add a limitation for the key_shared subscription type.
  2. Apply the new markdown syntax to more notes and tips.

The preview looks good.

image

Documentation

  • doc

@github-actions
Copy link

@momo-jun:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@github-actions
Copy link

@momo-jun:Thanks for providing doc info!

@github-actions github-actions bot added the doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. label May 23, 2022
@momo-jun
Copy link
Contributor Author

momo-jun commented May 23, 2022 •
edited
Loading

Hi @codelipenghui PTAL. Shall we apply this change to 2.10 or even more versions?
//cc @Anonymitaet

@Anonymitaet Anonymitaet added this to the 2.11.0 milestone May 24, 2022
@momo-jun
Copy link
Contributor Author

momo-jun commented Jun 8, 2022

Hi @codelipenghui can you pls review this PR, and shall we apply this change to 2.10 or even more versions?

@github-actions
Copy link

github-actions bot commented Jul 9, 2022

The pr had no activity for 30 days, mark with Stale label.

@github-actions github-actions bot added the Stale label Jul 9, 2022
@codelipenghui codelipenghui modified the milestones: 2.11.0, 2.12.0 Jul 26, 2022
@momo-jun
Copy link
Contributor Author

momo-jun commented Sep 28, 2022 •
edited
Loading

@codelipenghui thanks for your review. I've incorporated your suggestion. Can you please take another look?

@github-actions github-actions bot removed the Stale label Sep 28, 2022
@codelipenghui codelipenghui merged commit 048ccae into apache:master Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Anonymitaet Anonymitaet Anonymitaet approved these changes

@codelipenghui codelipenghui codelipenghui approved these changes

Assignees

@momo-jun momo-jun

Labels
doc Your PR contains doc changes, no matter whether the changes are in markdown or code files.
Projects
None yet
Milestone
3.0.0
3 participants
@momo-jun @codelipenghui @Anonymitaet