Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Documentation] Add Geo Replicated subscriptions documentation in website #5134

Closed
jiazhai opened this issue Sep 6, 2019 · 3 comments · Fixed by #5267
Closed

[Documentation] Add Geo Replicated subscriptions documentation in website #5134

jiazhai opened this issue Sep 6, 2019 · 3 comments · Fixed by #5267
Assignees
@Jennifer88huang-zz
Labels
doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. help wanted type/bug The PR fixed a bug or issue reported a bug
Milestone
2.5.0

Comments

@jiazhai
Copy link
Member

jiazhai commented Sep 6, 2019

In PIP-33, Geo Replicated subscriptions, feature is added, but documentation is not updated.
related PRs: #4396 #4299 #4340 #4354

This issue tries to track the documentation work.
@jiazhai jiazhai added type/bug The PR fixed a bug or issue reported a bug help wanted doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. labels Sep 6, 2019
@sijie sijie added this to the 2.5.0 milestone Sep 18, 2019
@sijie
Copy link
Member

sijie commented Sep 18, 2019

@jennifer88huang can you add this to the backlog? It is good to have this documentation added before 2.5.0 release.

@Jennifer88huang-zz
Copy link
Contributor

Sure, got it.

@Jennifer88huang-zz Jennifer88huang-zz self-assigned this Sep 18, 2019
@Jennifer88huang-zz
Copy link
Contributor

After reading PIP-33, and discussing with @zymap, we come to the conclusion that snapshot belongs to internal implementation, and users need not know it. If so, I'll not document how snapshot works in the user docs. If there is any misunderstanding, feel free to tell me.
Thing to be confirmed (@jiazhai @tuteng @zymap @merlimat) :

  • "The snapshots are taken periodically. Proposed default is every 1 second." "The frequency of this snapshot will be configurable in broker.conf" Is the snapshot set by default? Should we tell users the limitations?
  • Is "replicated subscription" enabled by default? or Is the default value of .replicateSubscriptionState true or false?

@Jennifer88huang-zz Jennifer88huang-zz mentioned this issue Sep 24, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jennifer88huang-zz Jennifer88huang-zz

Labels
doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. help wanted type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Milestone
2.5.0
Development

Successfully merging a pull request may close this issue.

[Issue 5134][docs] Add replicated subscription feature Jennifer88huang-zz/pulsar
3 participants
@sijie @jiazhai @Jennifer88huang-zz