Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AutoTopicCreationType partitioned not supported when passing through proxy #7903

Closed
KannarFr opened this issue Aug 26, 2020 · 8 comments · Fixed by #8048
Closed

AutoTopicCreationType partitioned not supported when passing through proxy #7903

KannarFr opened this issue Aug 26, 2020 · 8 comments · Fixed by #8048
Labels
area/proxy help wanted type/bug The PR fixed a bug or issue reported a bug

Comments

@KannarFr
Copy link
Contributor

KannarFr commented Aug 26, 2020

Describe the bug
When auto topic creation type is partitioned, the ServerCnx handles get PartitionMetadata by creatiing partitions in fetchPartitionedTopicMetadataCheckAllowAutoCreationAsync.

Proxy has other way to handle that and not support the partitioned topics auto creation because it directly answer the current ZK content and not creates partitions.

Expected behavior
Broker & Proxy should have the same way to handle auto topic creation.

@codelipenghui I finally get what what's wrong! Can you work on fixing it?

@jiazhai
Copy link
Member

jiazhai commented Aug 31, 2020

@KannarFr Thanks for the reporting. What is the behavior when using Proxy?

@KannarFr
Copy link
Contributor Author

@jiazhai BrokerDiscoveryProvider.getPartitionedTopicMetadata describes it.

@rudy2steiner
Copy link
Contributor

I'll try to fix it

@KannarFr
Copy link
Contributor Author

KannarFr commented Sep 7, 2020

@rudy2steiner are you working on it? :)

@rudy2steiner
Copy link
Contributor

Not yet, i will work on it in next weekend. you can do it if you are urgent

@KannarFr
Copy link
Contributor Author

KannarFr commented Sep 8, 2020

@rudy2steiner ok it's not urgent.

@yangou
Copy link

yangou commented May 2, 2021

Would this PR fix this issue also?
#10449

@rudy2steiner
Copy link
Contributor

Would this PR fix this issue also?
#10449

yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/proxy help wanted type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants