Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

brokerServiceUrl do not support mutli hosts in ipv6 environment #8092

Closed
wangjialing218 opened this issue Sep 21, 2020 · 3 comments · Fixed by #8120
Closed

brokerServiceUrl do not support mutli hosts in ipv6 environment #8092

wangjialing218 opened this issue Sep 21, 2020 · 3 comments · Fixed by #8120
Assignees
@wangjialing218
Labels
help wanted release/2.6.2 type/bug The PR fixed a bug or issue reported a bug
Milestone
2.7.0

Comments

@wangjialing218
Copy link
Contributor

Describe the bug
Set brokerServiceUrl in client.conf with mutli ipv6 host address like pulsar://[fec0:0:0:ffff::1]:6650,[fec0:0:0:ffff::2]:6650, when client connect to brokers it got such exception:
java.lang.IllegalArgumentException: Illegal character in port number at index 32: pulsar://[fec0:0:0:ffff::1]:6650,[fec0:0:0:ffff::2]:6650 at java.net.URI.create(URI.java:852) ~[na:1.8.0_131]

To Reproduce
Steps to reproduce the behavior:

  1. Start mutli brokers in ipv6 environment
  2. Set brokerServiceUrl in client.conf with mutli ipv6 host address and connect to brokers.

Expected behavior
Client can connect to brokers

Additional context
It seems ipv6 URI do not support mutli hosts split by comma. Is there any workaround to specify mutli ipv6 hosts in brokerServiceUrl ? or some code need changed in pulsar-client?
@wangjialing218 wangjialing218 added the type/bug The PR fixed a bug or issue reported a bug label Sep 21, 2020
@sijie sijie mentioned this issue Sep 21, 2020
Closed
@codelipenghui
Copy link
Contributor

Are you interested in pushing a PR for fixing this issue?

@codelipenghui codelipenghui added this to the 2.7.0 milestone Sep 22, 2020
@wangjialing218
Copy link
Contributor Author

I will work on fixing this issue.

@codelipenghui
Copy link
Contributor

Great, thanks @wangjialing218

@wangjialing218 wangjialing218 mentioned this issue Sep 24, 2020
Merged
codelipenghui pushed a commit that referenced this issue Sep 30, 2020
@wangjialing218
Support to specify multi ipv6 hosts in brokerServiceUrl (#8120)
c2a8283 
### Motivation
Fixes #8092

### Modifications

split url string by comma before create URI object when handling multi ipv6 hosts

### Verifying this change

This change added tests and can be verified as follows:

  - add testMultiIpv6Uri() in ServiceURI
lbenc135 pushed a commit to lbenc135/pulsar that referenced this issue Oct 3, 2020
@wangjialing218
Support to specify multi ipv6 hosts in brokerServiceUrl (apache#8120)
a97467f 
### Motivation
Fixes apache#8092

### Modifications

split url string by comma before create URI object when handling multi ipv6 hosts

### Verifying this change

This change added tests and can be verified as follows:

  - add testMultiIpv6Uri() in ServiceURI
wolfstudy pushed a commit that referenced this issue Oct 30, 2020
@wangjialing218 @wolfstudy
Support to specify multi ipv6 hosts in brokerServiceUrl (#8120)
08f9ead 
### Motivation
Fixes #8092

### Modifications

split url string by comma before create URI object when handling multi ipv6 hosts

### Verifying this change

This change added tests and can be verified as follows:

  - add testMultiIpv6Uri() in ServiceURI

(cherry picked from commit c2a8283)
huangdx0726 pushed a commit to huangdx0726/pulsar that referenced this issue Nov 13, 2020
@wangjialing218 @huangdx0726
Support to specify multi ipv6 hosts in brokerServiceUrl (apache#8120)
a5649eb 
### Motivation
Fixes apache#8092

### Modifications

split url string by comma before create URI object when handling multi ipv6 hosts

### Verifying this change

This change added tests and can be verified as follows:

  - add testMultiIpv6Uri() in ServiceURI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wangjialing218 wangjialing218

Labels
help wanted release/2.6.2 type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Milestone
2.7.0
Development

Successfully merging a pull request may close this issue.

[Issue 8092]support to specify multi ipv6 hosts in brokerServiceUrl wangjialing218/pulsar
2 participants
@codelipenghui @wangjialing218