Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue 8092]support to specify multi ipv6 hosts in brokerServiceUrl #8120

Merged

Conversation

wangjialing218
Copy link
Contributor

Motivation

Fixes #8092

Modifications

split url string by comma before create URI object when handling multi ipv6 hosts

Verifying this change

This change added tests and can be verified as follows:

  • add testMultiIpv6Uri() in ServiceURITest.java

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (no)

Documentation

  • Does this pull request introduce a new feature? (no)

@jiazhai
Copy link
Member

jiazhai commented Sep 24, 2020

/pulsarbot run-failure-checks

2 similar comments
@wangjialing218
Copy link
Contributor Author

/pulsarbot run-failure-checks

@wangjialing218
Copy link
Contributor Author

/pulsarbot run-failure-checks

@wangjialing218
Copy link
Contributor Author

/pulsarbot run-failure-checks

@jiazhai jiazhai added this to the 2.7.0 milestone Sep 24, 2020
@wangjialing218
Copy link
Contributor Author

/pulsarbot run-failure-checks

@codelipenghui codelipenghui merged commit c2a8283 into apache:master Sep 30, 2020
lbenc135 pushed a commit to lbenc135/pulsar that referenced this pull request Oct 3, 2020
### Motivation
Fixes apache#8092

### Modifications

split url string by comma before create URI object when handling multi ipv6 hosts

### Verifying this change

This change added tests and can be verified as follows:

  - add testMultiIpv6Uri() in ServiceURI
@wangjialing218 wangjialing218 deleted the branch-support-multihosts-ipv6 branch October 9, 2020 01:13
@eatSummer
Copy link

I have some questions to ask you about pulsar (ipv6)
this is my email 2389095767@qq.com

wolfstudy pushed a commit that referenced this pull request Oct 30, 2020
### Motivation
Fixes #8092

### Modifications

split url string by comma before create URI object when handling multi ipv6 hosts

### Verifying this change

This change added tests and can be verified as follows:

  - add testMultiIpv6Uri() in ServiceURI

(cherry picked from commit c2a8283)
huangdx0726 pushed a commit to huangdx0726/pulsar that referenced this pull request Nov 13, 2020
### Motivation
Fixes apache#8092

### Modifications

split url string by comma before create URI object when handling multi ipv6 hosts

### Verifying this change

This change added tests and can be verified as follows:

  - add testMultiIpv6Uri() in ServiceURI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

brokerServiceUrl do not support mutli hosts in ipv6 environment
4 participants