[pulsar-client] Make it possible to disable poolMessages #12108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhotari
approved these changes
Sep 22, 2021
315157973
approved these changes
Sep 22, 2021
MarvinCai
reviewed
Sep 22, 2021
| @@ -139,7 +139,7 @@ | |||
| @Parameter(names = { "-st", "--schema-type"}, description = "Set a schema type on the consumer, it can be 'bytes' or 'auto_consume'") | |||
| private String schematype = "bytes"; | |||
|
|
|||
| @Parameter(names = { "-pm", "--pool-messages" }, description = "Use the pooled message") | |||
| @Parameter(names = { "-pm", "--pool-messages" }, description = "Use the pooled message", arity = 1) | |||
There was a problem hiding this comment.
can we also update the doc here?
codelipenghui
pushed a commit
that referenced
this pull request
Sep 29, 2021
(cherry picked from commit 4aae519)
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Details are similar to [pulsar-perf] Make it possible to disable poolMessages
Documentation