[pulsar-perf] Make it possible to disable poolMessages #12090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- JCommander requires passing arity = 1 to boolean parameters that have a default value of true.
lhotari
requested review from
merlimat,
rdhabalia,
eolivelli and
codelipenghui
|
LGTM. Should we also cover other similar parameters? |
yuruguo
reviewed
Sep 18, 2021
| @Parameter(names = {"--batch-index-ack" }, description = "Enable or disable the batch index acknowledgment") | ||
| public boolean batchIndexAck = false; | ||
|
|
||
| @Parameter(names = { "-pm", "--pool-messages" }, description = "Use the pooled message") | ||
| @Parameter(names = { "-pm", "--pool-messages" }, description = "Use the pooled message", arity = 1) |
There was a problem hiding this comment.
Good catch！Should other parameter that type is boolean be handled like this? such as --replicated, --batch-index-ack, --auto_ack_chunk_q_full etc.
There was a problem hiding this comment.
It would be a breaking change. This is only necessary for boolean options that default to true.
It would be a breaking change. This is only necessary for boolean options that default to true. |
yuruguo
approved these changes
Sep 19, 2021
merlimat
approved these changes
Sep 20, 2021
codelipenghui
pushed a commit
that referenced
this pull request
Sep 24, 2021
- JCommander requires passing arity = 1 to boolean parameters that have a default value of true. (cherry picked from commit 898582b)
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
- JCommander requires passing arity = 1 to boolean parameters that have a default value of true.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In Pulsar 2.8.0 with pulsar-perf, I hit the bug #11824 where the
pulsar-perf consumestops consuming some partitions.As a workaround, I tried to pass
-pm falseor--pool-messages falseon the command line, but this resulted in error message:The size of topics list should be equal to --num-topicsThe problem is that JCommander doesn't expect arguments to boolean parameters by default.
This is explained in the JCommander manual and issue comment cbeust/jcommander#129 (comment) .
Modifications
arity = 1to the JCommander Parameter annotation.arity = 1to boolean parameters that have a default value of true.